Skip to content

Commit 9de1702

Browse files
committed
Document use of redundant feature flag API call
1 parent efded22 commit 9de1702

3 files changed

Lines changed: 9 additions & 1 deletion

File tree

lib/analyze-action.js

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/analyze-action.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/analyze-action.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,10 @@ async function run() {
111111
repositoryNwo,
112112
logger
113113
);
114+
// We currently perform an API request in both the `init` and `analyze` Actions to determine
115+
// what feature flags are enabled. At the time of writing, this redundant API call is acceptable
116+
// to us, but if we wanted to avoid it, we could do so by serializing the feature flags as part
117+
// of the config file.
114118
void featureFlags.preloadFeatureFlags();
115119

116120
await runFinalize(outputDir, threads, memory, config, logger);

0 commit comments

Comments
 (0)