Skip to content

Commit 823bb21

Browse files
committed
Add a default value for wait-for-processing.
1 parent 49fc4c9 commit 823bb21

4 files changed

Lines changed: 7 additions & 5 deletions

File tree

analyze/action.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ inputs:
5454
default: "true"
5555
wait-for-processing:
5656
description: If true, the Action will wait for the uploaded SARIF to be processed before completing.
57-
required: false
57+
required: true
58+
default: "false"
5859
token:
5960
default: ${{ github.token }}
6061
matrix:

lib/upload-lib.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/upload-lib.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ export async function uploadFromActions(
161161
actionsUtil.getWorkflowRunID(),
162162
actionsUtil.getRequiredInput("checkout_path"),
163163
actionsUtil.getRequiredInput("matrix"),
164-
actionsUtil.getOptionalInput("wait-for-processing") === "true",
164+
actionsUtil.getRequiredInput("wait-for-processing") === "true",
165165
gitHubVersion,
166166
apiDetails,
167167
logger

upload-sarif/action.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ inputs:
66
description: |
77
The SARIF file or directory of SARIF files to be uploaded to GitHub code scanning.
88
See https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/uploading-a-sarif-file-to-github#uploading-a-code-scanning-analysis-with-github-actions
9-
for information on the maximum number of results and maximum file size supported by code scanning.
9+
for information on the maximum number of results and maximum file size supported by code scanning.
1010
required: false
1111
default: '../results'
1212
checkout_path:
@@ -22,7 +22,8 @@ inputs:
2222
required: false
2323
wait-for-processing:
2424
description: If true, the Action will wait for the uploaded SARIF to be processed before completing.
25-
required: false
25+
required: true
26+
default: "false"
2627
runs:
2728
using: 'node12'
2829
main: '../lib/upload-sarif-action.js'

0 commit comments

Comments
 (0)