Skip to content

Commit 6645c55

Browse files
RasmusWLmarcogario
andauthored
Apply suggestions from code review
Co-authored-by: Marco Gario <marcogario@github.com>
1 parent 3495596 commit 6645c55

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

python-setup/extractor_version.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ def suppress_stdout_stderr():
3030

3131

3232
def get_extractor_version(codeql_base_dir: str, quiet: bool = True) -> int:
33-
3433
extractor_dir = os.path.join(codeql_base_dir, 'python', 'tools')
3534
sys.path = [extractor_dir] + sys.path
3635

@@ -50,4 +49,4 @@ def get_extractor_version(codeql_base_dir: str, quiet: bool = True) -> int:
5049
if __name__ == "__main__":
5150
codeql_base_dir = sys.argv[1]
5251
version = get_extractor_version(codeql_base_dir)
53-
print('{!r}'.format(version))
52+
print('{!r}'.format(version))

python-setup/install_tools.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ python3 -m pip install --user virtualenv
2121
# venv is required for installation of poetry or pipenv (I forgot which)
2222
sudo apt-get install -y python3-venv
2323

24-
# We're install poetry with pip instead of the recommended way, since the recommended way
24+
# We install poetry with pip instead of the recommended way, since the recommended way
2525
# caused some problem since `poetry run` gives output like:
2626
#
2727
# /root/.poetry/lib/poetry/_vendor/py2.7/subprocess32.py:149: RuntimeWarning: The _posixsubprocess module is not being used. Child process reliability may suffer if your program uses threads.

0 commit comments

Comments
 (0)