Skip to content

Commit 3f6d759

Browse files
committed
more cleanup
1 parent 8c5a043 commit 3f6d759

2 files changed

Lines changed: 2 additions & 19 deletions

File tree

.github/pull_request_template.md

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
### Merge / deployment checklist
22

3-
- Run test builds as necessary. Can be on this repository or [elsewhere](https://github.com/github/turbo-scan/#testing-changes-to-codeql-action) as needed in order to test the change.
3+
- Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in otehr repos!
44
- [ ] CodeQL using init/finish actions
55
- [ ] 3rd party tool using upload action
66
- [ ] Confirm this change is backwards compatible with existing workflows.
7-
- [ ] Confirm the [readme](https://github.com/github/codeql-action/blob/master/README.md) and [sarif-demo](https://github.com/Anthophila/sarif-demo) have been updated if necessary.
8-
9-
### Rollout plan for codeql-action
10-
https://github.com/github/dsp-code-scanning/blob/master/docs/code-scanning-action-rollout-plan.md
7+
- [ ] Confirm the [readme](https://github.com/github/codeql-action/blob/master/README.md) has been updated if necessary.

.github/workflows/integration-testing.yml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,6 @@ name: "Integration Testing"
22

33
on: [push]
44

5-
# Adding new repositories to be integration tested
6-
# 0) Repo needs to be set up with the codeql action working (e.g. have a CODEQL_SSH_KEY as a secret)
7-
# https://github.com/github/dsp-code-scanning/issues/312#issuecomment-577631601
8-
# 1) Add the `codeql-testuser` to the repository with WRITE permissions (Important!)
9-
# 2) Put a copy of the workflow as `.github/workflows/integration-test.yml` in the target repo. You can find a copy of the workflow here: https://raw.githubusercontent.com/Anthophila/amazon-cognito-js-copy/master/.github/workflows/integration-test.ym
10-
# 3) Copy and paste the block below filling in the repo owner/name
11-
# curl -X POST \
12-
# -H "Authorization: Bearer ${{ secrets.CODEQL_TESTING_TOKEN }}" \
13-
# -H "Accept: application/vnd.github.everest-preview+json" \
14-
# https://api.github.com/repos/OWNER/NAME/dispatches \
15-
# -d '{"event_type":"codeql-integration","client_payload": {"sha": "${{ github.sha }}"}}'
16-
17-
# add another job that creates a new check suite using the API, send check suite id in our payload
18-
195
jobs:
206
dispatch-events:
217
if: github.event.repository.full_name == 'github/codeql-action'

0 commit comments

Comments
 (0)