Merge pull request #233 from miqh/fix/205

Resolve violations of no-useless-escape lint

Author: Chris Raynor

.eslintrc.json

@@ -48,7 +48,6 @@
             "github/no-then": "off",
             "import/no-extraneous-dependencies": "off",
             "no-shadow": "off",
-            "no-useless-escape": "off",
             "sort-imports": "off"
         }
     }]

lib/analysis-paths.js

@@ -6,7 +6,7 @@ function isInterpretedLanguage(language): boolean {
 }
 
 // Matches a string containing only characters that are legal to include in paths on windows.
-export const legalWindowsPathCharactersRegex = /^[^<>:"\|?]*$/;
+export const legalWindowsPathCharactersRegex = /^[^<>:"|?]*$/;
 
 // Builds an environment variable suitable for LGTM_INDEX_INCLUDE or LGTM_INDEX_EXCLUDE
 function buildIncludeExcludeEnvVar(paths: string[]): string {

lib/analysis-paths.js.map

@@ -375,7 +375,7 @@ const pathStarsRegex = /.*(?:\*\*[^/].*|\*\*$|[^/]\*\*.*)/;
 
 // Characters that are supported by filters in workflows, but not by us.
 // See https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
-const filterPatternCharactersRegex = /.*[\?\+\[\]!].*/;
+const filterPatternCharactersRegex = /.*[?+[\]!].*/;
 
 // Checks that a paths of paths-ignore entry is valid, possibly modifying it
 // to make it valid, or if not possible then throws an error.

lib/config-utils.js

@@ -77,7 +77,7 @@ export async function toolrunnerErrorCatcher(
       return returnState;
     } else {
       throw new Error(
-        `The process \'${commandLine}\' failed with exit code ${returnState}`
+        `The process '${commandLine}' failed with exit code ${returnState}`
       );
     }
   } else {