+ "details": "## Summary\n \ntelejson versions prior to 6.0.0 (released 2022) are vulnerable to DOM-based Cross-Site Scripting (XSS) through unsafe deserialisation. Attacker-controlled input from the `_constructor-name_` property in parsed JSON is passed directly to `new Function()` without sanitisation, allowing arbitrary JavaScript execution.\n \n## Affected versions\n \n| Package | Affected | Fixed |\n|----------|-----------|----------|\n| telejson | < 6.0.0 | >= 6.0.0 |\n \n \n## Details\n \ntelejson's `parse()` function uses a custom reviver to reconstruct JavaScript objects from serialised JSON. When processing objects with a `_constructor-name_` property, the reviver passes the constructor name directly to `new Function()` to recreate the object's prototype.\n \nIn versions prior to 6.0.0, this constructor name is not sanitised. An attacker who can deliver a crafted JSON payload to `telejson.parse()` (for example, via `postMessage` in applications that use telejson for cross-frame communication) can inject arbitrary JavaScript into the `new Function()` call.\n \n**Vulnerable code** ([`src/index.ts`, lines 293-299 at v5.3.3](https://github.com/storybookjs/telejson/blob/v5.3.3/src/index.ts#L293-L299)):\n \n```ts\nif (isObject<ValueContainer>(value) && value['_constructor-name_']) {\n const name = value['_constructor-name_'];\n if (name !== 'Object') {\n const Fn = new Function(`return function ${name}(){}`)();\n Object.setPrototypeOf(value, new Fn());\n }\n```\n \n**Fixed code** ([`src/index.ts`, lines 340-346 at v6.0.0](https://github.com/storybookjs/telejson/blob/v6.0.0/src/index.ts#L340-L346)):\n \n```ts\nif (isObject<ValueContainer>(value) && value['_constructor-name_'] && options.allowFunction) {\n const name = value['_constructor-name_'];\n if (name !== 'Object') {\n const Fn = new Function(`return function ${name.replace(/[\\W_]+/g, '')}(){}`)();\n Object.setPrototypeOf(value, new Fn());\n }\n```\n \nThe fix introduces two mitigations: a character allowlist via regex that strips non-word characters before they reach `new Function()`, and gating the entire code path behind the `allowFunction` option.\n \n## Impact\n \nAn attacker can execute arbitrary JavaScript in the context of the application using the vulnerable telejson version. Depending on the application, this could enable session hijacking, credential theft, or arbitrary DOM manipulation.\n \n## Remediation\n \nUpgrade to telejson >= 6.0.0.",
0 commit comments