Merge pull request #488 from shuofengzhang/trim-exemption-whitespace

fix: Trim whitespace in repo-specific exemptions

Author: zkoppert

env.py

@@ -71,7 +71,9 @@ def parse_repo_specific_exemptions(repo_specific_exemptions_str: str) -> dict:
             ):  # Account for final ; in the repo_specific_exemptions_str
                 continue
             repo, ecosystems = exemption.split(":")
+            cleaned_ecosystems = []
             for ecosystem in ecosystems.split(","):
+                ecosystem = ecosystem.strip()
                 if ecosystem not in [
                     "bundler",
                     "cargo",
@@ -88,9 +90,8 @@ def parse_repo_specific_exemptions(repo_specific_exemptions_str: str) -> dict:
                     raise ValueError(
                         "REPO_SPECIFIC_EXEMPTIONS environment variable not formatted correctly. Unrecognized package-ecosystem."
                     )
-            exemptions_dict[repo.strip()] = [
-                ecosystem.strip() for ecosystem in ecosystems.split(",")
-            ]
+                cleaned_ecosystems.append(ecosystem)
+            exemptions_dict[repo.strip()] = cleaned_ecosystems
     return exemptions_dict
 
 

test_env.py

@@ -156,6 +156,61 @@ def test_get_env_vars_with_org_and_repo_specific_exemptions(self):
         result = get_env_vars(True)
         self.assertEqual(result, expected_result)
 
+    @patch.dict(
+        os.environ,
+        {
+            "ORGANIZATION": "my_organization",
+            "EXEMPT_REPOS": "repo4,repo5",
+            "GH_TOKEN": "my_token",
+            "TYPE": "issue",
+            "TITLE": "Dependabot Alert custom title",
+            "BODY": "Dependabot custom body",
+            "CREATED_AFTER_DATE": "2020-01-01",
+            "COMMIT_MESSAGE": "Create dependabot configuration",
+            "PROJECT_ID": "123",
+            "GROUP_DEPENDENCIES": "false",
+            "REPO_SPECIFIC_EXEMPTIONS": "repo1:gomod, docker;",
+        },
+        clear=True,
+    )
+    def test_get_env_vars_repo_specific_exemptions_trims_whitespace(self):
+        """Test that REPO_SPECIFIC_EXEMPTIONS trims whitespace in ecosystems."""
+        expected_result = (
+            "my_organization",
+            [],
+            "",  # search_query
+            None,
+            None,
+            b"",
+            False,
+            "my_token",
+            "",
+            ["repo4", "repo5"],
+            "issue",
+            "Dependabot Alert custom title",
+            "Dependabot custom body",
+            "2020-01-01",
+            False,
+            "Create dependabot configuration",
+            "123",
+            False,
+            ["internal", "private", "public"],
+            None,  # batch_size
+            True,  # enable_security_updates
+            [],  # exempt_ecosystems
+            False,  # update_existing
+            {
+                "repo1": ["gomod", "docker"],
+            },  # repo_specific_exemptions
+            "weekly",  # schedule
+            "",  # schedule_day
+            None,  # team_name
+            [],  # labels
+            None,
+        )
+        result = get_env_vars(True)
+        self.assertEqual(result, expected_result)
+
     @patch.dict(
         os.environ,
         {