[~TASK] Fixed FireGento CS violations

Author: therouv

src/app/code/community/FireGento/AdminMonitoring/Block/Adminhtml/History/Grid.php

@@ -219,15 +219,15 @@ public function showOldContent($oldContent, FireGento_AdminMonitoring_Model_Hist
         $oldContent = $this->decodeContent($oldContent);
 
         if (is_array($oldContent)) {
-           if (count($oldContent) > 0) {
-               foreach ($oldContent as $key => $value) {
-                   $attributeName = $this->getMonitoringHelper()
-                       ->getAttributeNameByTypeAndCode($row->getObjectType(), $key);
-                   $cell .= $this->formatCellContent($attributeName, $value);
-               }
-           } else {
-               return $this->__('not available');
-           }
+            if (count($oldContent) > 0) {
+                foreach ($oldContent as $key => $value) {
+                    $attributeName = $this->getMonitoringHelper()
+                        ->getAttributeNameByTypeAndCode($row->getObjectType(), $key);
+                    $cell .= $this->formatCellContent($attributeName, $value);
+                }
+            } else {
+                return $this->__('not available');
+            }
         }
 
         return $this->wrapColor($cell, '#ff0000');
@@ -236,7 +236,7 @@ public function showOldContent($oldContent, FireGento_AdminMonitoring_Model_Hist
     /**
      * Decode the given content string.
      *
-     * @param  string $content
+     * @param  string $content Content to decode
      * @return mixed
      */
     private function decodeContent($content)
@@ -259,8 +259,8 @@ private function entities($string)
     /**
      * Format the cell content
      *
-     * @param  array|string $value Value
      * @param  string       $key   Key
+     * @param  array|string $value Value
      * @return string Formatted string
      */
     private function formatCellContent($key, $value)

src/app/code/community/FireGento/AdminMonitoring/Helper/Data.php

@@ -39,7 +39,7 @@ class FireGento_AdminMonitoring_Helper_Data extends Mage_Core_Helper_Abstract
     /**
      * Retrieve the attribute type by provided class name
      *
-     * @param  string      $className Class Name
+     * @param  string $className Class Name
      * @return string|bool Attribute Type or false
      */
     public function getAttributeTypeByClassName($className)

src/app/code/community/FireGento/AdminMonitoring/Model/History/Data.php

@@ -35,7 +35,7 @@ class FireGento_AdminMonitoring_Model_History_Data
     /**
      * Init the saved model
      *
-     * @param Mage_Core_Model_Abstract $savedModel
+     * @param Mage_Core_Model_Abstract $savedModel Model which is to be saved
      */
     public function __construct(Mage_Core_Model_Abstract $savedModel)
     {

src/app/code/community/FireGento/AdminMonitoring/Model/History/Diff.php

@@ -35,7 +35,7 @@ class FireGento_AdminMonitoring_Model_History_Diff
     /**
      * Init the data model
      *
-     * @param FireGento_AdminMonitoring_Model_History_Data $dataModel
+     * @param FireGento_AdminMonitoring_Model_History_Data $dataModel History Data Model
      */
     public function __construct(FireGento_AdminMonitoring_Model_History_Data $dataModel)
     {

src/app/code/community/FireGento/AdminMonitoring/Model/Observer/Model/Abstract.php

@@ -43,6 +43,8 @@ abstract class FireGento_AdminMonitoring_Model_Observer_Model_Abstract
     private $dataModel;
 
     /**
+     * Abstract method for retrieving the history action.
+     *
      * @return int
      */
     abstract protected function getAction();

src/app/code/community/FireGento/AdminMonitoring/Model/Observer/Model/Save.php

@@ -41,7 +41,7 @@ class FireGento_AdminMonitoring_Model_Observer_Model_Save
     /**
      * Handle the model_save_after event.
      *
-     * @param Varien_Event_Observer $observer
+     * @param Varien_Event_Observer $observer Observer Instance
      */
     public function modelAfter(Varien_Event_Observer $observer)
     {
@@ -52,7 +52,7 @@ public function modelAfter(Varien_Event_Observer $observer)
     /**
      * Set the current hash of the given model.
      *
-     * @param Mage_Core_Model_Abstract $model
+     * @param Mage_Core_Model_Abstract $model Object
      */
     private function setCurrentHash(Mage_Core_Model_Abstract $model)
     {

src/app/code/community/FireGento/AdminMonitoring/Model/Observer/Product/Attribute/Update.php

@@ -28,7 +28,7 @@
 class FireGento_AdminMonitoring_Model_Observer_Product_Attribute_Update
     extends FireGento_AdminMonitoring_Model_Observer_Log
 {
-    const XML_PATH_ADMINMONITORING_LOG_PRODUCT_MASS_UPDATE = 'admin/firegento_adminmonitoring/product_mass_update_logging';
+    const XML_PATH_ADMINMONITORING_PROD_ATTR_UPDATE = 'admin/firegento_adminmonitoring/product_mass_update_logging';
 
     /**
      * Observe the catalog product attribute update before
@@ -38,7 +38,7 @@ class FireGento_AdminMonitoring_Model_Observer_Product_Attribute_Update
      */
     public function catalogProductAttributeUpdateBefore(Varien_Event_Observer $observer)
     {
-        if (!Mage::getStoreConfigFlag(self::XML_PATH_ADMINMONITORING_LOG_PRODUCT_MASS_UPDATE)) {
+        if (!Mage::getStoreConfigFlag(self::XML_PATH_ADMINMONITORING_PROD_ATTR_UPDATE)) {
             return;
         }
 

src/app/code/community/FireGento/AdminMonitoring/Model/RowUrl/Model/Abstract.php

@@ -28,17 +28,23 @@
 abstract class FireGento_AdminMonitoring_Model_RowUrl_Model_Abstract
 {
     /**
+     * Abstract method for retrieving the class name.
+     *
      * @return string
      */
     abstract protected function getClassName();
 
     /**
+     * Abstract method for retrieving the route path.
+     *
      * @return string
      */
     abstract protected function getRoutePath();
 
     /**
-     * @param  Mage_Core_Model_Abstract $model
+     * Abstract method for retrieving the route params.
+     *
+     * @param  Mage_Core_Model_Abstract $model Object
      * @return array
      */
     abstract protected function getRouteParams(Mage_Core_Model_Abstract $model);