Skip to content

Commit c66309a

Browse files
committed
[TASK] Define protected functions with leading underscore
1 parent 2e0debe commit c66309a

5 files changed

Lines changed: 20 additions & 20 deletions

File tree

src/app/code/community/FireGento/AdminMonitoring/Model/RowUrl/Model/Abstract.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,22 +32,22 @@ abstract class FireGento_AdminMonitoring_Model_RowUrl_Model_Abstract
3232
*
3333
* @return string
3434
*/
35-
abstract protected function getClassName();
35+
abstract protected function _getClassName();
3636

3737
/**
3838
* Abstract method for retrieving the route path.
3939
*
4040
* @return string
4141
*/
42-
abstract protected function getRoutePath();
42+
abstract protected function _getRoutePath();
4343

4444
/**
4545
* Abstract method for retrieving the route params.
4646
*
4747
* @param Mage_Core_Model_Abstract $model Object
4848
* @return array
4949
*/
50-
abstract protected function getRouteParams(Mage_Core_Model_Abstract $model);
50+
abstract protected function _getRouteParams(Mage_Core_Model_Abstract $model);
5151

5252
/**
5353
* Sets the row url in the transport object for a cms_page model
@@ -58,11 +58,11 @@ public function setRowUrl(Varien_Event_Observer $observer)
5858
{
5959
/* @var $history FireGento_AdminMonitoring_Model_History */
6060
$history = $observer->getHistory();
61-
$rowUrl = $this->getRowUrl(
61+
$rowUrl = $this->_getRowUrl(
6262
$history,
63-
$this->getClassName(),
64-
$this->getRoutePath(),
65-
$this->getRouteParams($history->getOriginalModel())
63+
$this->_getClassName(),
64+
$this->_getRoutePath(),
65+
$this->_getRouteParams($history->getOriginalModel())
6666
);
6767

6868
if ($rowUrl) {
@@ -79,7 +79,7 @@ public function setRowUrl(Varien_Event_Observer $observer)
7979
* @param array $routeParams Route Params
8080
* @return Mage_Adminhtml_Model_Url
8181
*/
82-
public function getRowUrl(FireGento_AdminMonitoring_Model_History $history, $className, $routePath, $routeParams)
82+
protected function _getRowUrl(FireGento_AdminMonitoring_Model_History $history, $className, $routePath, $routeParams)
8383
{
8484
/* @var $history FireGento_AdminMonitoring_Model_History */
8585
if (!$history->isDelete()) {

src/app/code/community/FireGento/AdminMonitoring/Model/RowUrl/Model/Customer.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class FireGento_AdminMonitoring_Model_RowUrl_Model_Customer
3333
*
3434
* @return string Class Name
3535
*/
36-
protected function getClassName()
36+
protected function _getClassName()
3737
{
3838
return 'Mage_Customer_Model_Customer';
3939
}
@@ -43,7 +43,7 @@ protected function getClassName()
4343
*
4444
* @return string Route Path
4545
*/
46-
protected function getRoutePath()
46+
protected function _getRoutePath()
4747
{
4848
return 'adminhtml/customer/edit';
4949
}
@@ -54,7 +54,7 @@ protected function getRoutePath()
5454
* @param Mage_Core_Model_Abstract $model Model
5555
* @return array Route Params
5656
*/
57-
protected function getRouteParams(Mage_Core_Model_Abstract $model)
57+
protected function _getRouteParams(Mage_Core_Model_Abstract $model)
5858
{
5959
return array(
6060
'id' => $model->getId()

src/app/code/community/FireGento/AdminMonitoring/Model/RowUrl/Model/Order.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class FireGento_AdminMonitoring_Model_RowUrl_Model_Order
3333
*
3434
* @return string Class Name
3535
*/
36-
protected function getClassName()
36+
protected function _getClassName()
3737
{
3838
return 'Mage_Sales_Model_Order';
3939
}
@@ -43,7 +43,7 @@ protected function getClassName()
4343
*
4444
* @return string Route Path
4545
*/
46-
protected function getRoutePath()
46+
protected function _getRoutePath()
4747
{
4848
return 'adminhtml/sales_order/view';
4949
}
@@ -54,7 +54,7 @@ protected function getRoutePath()
5454
* @param Mage_Core_Model_Abstract $model Model
5555
* @return array Route Params
5656
*/
57-
protected function getRouteParams(Mage_Core_Model_Abstract $model)
57+
protected function _getRouteParams(Mage_Core_Model_Abstract $model)
5858
{
5959
return array(
6060
'order_id' => $model->getId()

src/app/code/community/FireGento/AdminMonitoring/Model/RowUrl/Model/Page.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class FireGento_AdminMonitoring_Model_RowUrl_Model_Page
3333
*
3434
* @return string Class Name
3535
*/
36-
protected function getClassName()
36+
protected function _getClassName()
3737
{
3838
return 'Mage_Cms_Model_Page';
3939
}
@@ -43,7 +43,7 @@ protected function getClassName()
4343
*
4444
* @return string Route Path
4545
*/
46-
protected function getRoutePath()
46+
protected function _getRoutePath()
4747
{
4848
return 'adminhtml/cms_page/edit';
4949
}
@@ -54,7 +54,7 @@ protected function getRoutePath()
5454
* @param Mage_Core_Model_Abstract $model Model
5555
* @return array Route Params
5656
*/
57-
protected function getRouteParams(Mage_Core_Model_Abstract $model)
57+
protected function _getRouteParams(Mage_Core_Model_Abstract $model)
5858
{
5959
return array(
6060
'page_id' => $model->getId()

src/app/code/community/FireGento/AdminMonitoring/Model/RowUrl/Model/Product.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class FireGento_AdminMonitoring_Model_RowUrl_Model_Product
3333
*
3434
* @return string Class Name
3535
*/
36-
protected function getClassName()
36+
protected function _getClassName()
3737
{
3838
return 'Mage_Catalog_Model_Product';
3939
}
@@ -43,7 +43,7 @@ protected function getClassName()
4343
*
4444
* @return string Route Path
4545
*/
46-
protected function getRoutePath()
46+
protected function _getRoutePath()
4747
{
4848
return 'adminhtml/catalog_product/edit';
4949
}
@@ -54,7 +54,7 @@ protected function getRoutePath()
5454
* @param Mage_Core_Model_Abstract $model Model
5555
* @return array Route Params
5656
*/
57-
protected function getRouteParams(Mage_Core_Model_Abstract $model)
57+
protected function _getRouteParams(Mage_Core_Model_Abstract $model)
5858
{
5959
return array(
6060
'id' => $model->getId(),

0 commit comments

Comments
 (0)