Merge pull request #126 from norgeindian/patch-1

Add category_path_seperator getter

Author: sprankhub

Model/Config.php

@@ -17,8 +17,7 @@ class Config extends AbstractHelper
     private const XML_PATH_VALIDATION_STRATEGY     = 'fastsimpleimport/default/validation_strategy';
     private const XML_PATH_ALLOWED_ERROR_COUNT     = 'fastsimpleimport/default/allowed_error_count';
     private const XML_PATH_IMPORT_IMAGES_FILE_FIR  = 'fastsimpleimport/default/import_images_file_dir';
-
-    public const  XML_PATH_CATEGORY_PATH_SEPERATOR = 'fastsimpleimport/default/category_path_seperator';
+    private const XML_PATH_CATEGORY_PATH_SEPERATOR = 'fastsimpleimport/default/category_path_seperator';
 
     public function __construct(
         Context $context
@@ -55,4 +54,9 @@ public function getImportFileDir(): string
     {
         return $this->scopeConfig->getValue(self::XML_PATH_IMPORT_IMAGES_FILE_FIR);
     }
+    
+    public function getCategoryPathSeparator(): string
+    {
+        return $this->scopeConfig->getValue(self::XML_PATH_CATEGORY_PATH_SEPERATOR);
+    }
 }

Model/Import/Category.php

@@ -216,6 +216,7 @@ class Category extends \Magento\ImportExport\Model\Import\AbstractEntity
     private CategoryUrlRewriteGenerator $categoryUrlRewriteGenerator;
     private UrlPersistInterface $urlPersist;
     private CategoryRepositoryInterface $categoryRepository;
+    private Config $config;
 
     public function __construct(
         StringUtils $string,
@@ -239,6 +240,7 @@ public function __construct(
         CategoryUrlRewriteGenerator $categoryUrlRewriteGenerator,
         CategoryRepositoryInterface $categoryRepository,
         UrlPersistInterface $urlPersist,
+        Config $config,
         array $data = []
     ) {
         parent::__construct(
@@ -279,8 +281,9 @@ public function __construct(
             ->initAttributes()
             ->initAttributeSetId();
 
-        $this->entityTable = $this->defaultCategory->getResource()->getEntityTable();
+        $this->entityTable                  = $this->defaultCategory->getResource()->getEntityTable();
         $this->categoryImportVersionFeature = $this->versionFeatures->create('CategoryImportVersion');
+        $this->config                       = $config;
     }
 
     /**
@@ -382,10 +385,7 @@ private function initCategories(): self
                     $this->categoriesWithRoots[$rootCategoryName] = [];
                 }
 
-                $index = $this->implodeEscaped(
-                    (string) $this->_scopeConfig->getValue(Config::XML_PATH_CATEGORY_PATH_SEPERATOR),
-                    $path
-                );
+                $index = $this->implodeEscaped($this->config->getCategoryPathSeparator(), $path);
                 $this->categoriesWithRoots[$rootCategoryName][$index] = [
                     'entity_id' => $category->getId(),
                     CategoryInterface::KEY_PATH => $category->getData(CategoryInterface::KEY_PATH),
@@ -417,10 +417,7 @@ private function implodeEscaped(string $glue, array $array): string
         foreach ($array as $value) {
             $newArray[] = str_replace($glue, '\\' . $glue, $value);
         }
-        return implode(
-            $this->_scopeConfig->getValue(Config::XML_PATH_CATEGORY_PATH_SEPERATOR),
-            $newArray
-        );
+        return implode($this->config->getCategoryPathSeparator(), $newArray);
     }
 
     /**
@@ -861,10 +858,7 @@ private function getCategoryName(array $rowData): string
             return $rowData[CategoryModel::KEY_NAME];
         }
 
-        $categoryParts = $this->explodeEscaped(
-            (string) $this->_scopeConfig->getValue(Config::XML_PATH_CATEGORY_PATH_SEPERATOR),
-            $rowData[self::COL_CATEGORY]
-        );
+        $categoryParts = $this->explodeEscaped($this->config->getCategoryPathSeparator(), $rowData[self::COL_CATEGORY]);
         return end($categoryParts);
     }
 
@@ -911,15 +905,10 @@ protected function getParentCategory(array $rowData)
             );
             $parent = $categoryParts[count($categoryParts) - 2];
         } else {
-            $categoryParts = $this->explodeEscaped(
-                (string) $this->_scopeConfig->getValue(Config::XML_PATH_CATEGORY_PATH_SEPERATOR),
-                $rowData[self::COL_CATEGORY]
-            );
+            $categoryParts = $this->explodeEscaped($this->config->getCategoryPathSeparator(),
+                $rowData[self::COL_CATEGORY]);
             array_pop($categoryParts);
-            $parent = $this->implodeEscaped(
-                (string) $this->_scopeConfig->getValue(Config::XML_PATH_CATEGORY_PATH_SEPERATOR),
-                $categoryParts
-            );
+            $parent = $this->implodeEscaped($this->config->getCategoryPathSeparator(), $categoryParts);
         }
 
         if ($parent) {