Skip to content

Commit bb223e1

Browse files
authored
Merge pull request #24719 from dvdksn/worktree-agent-a7a975f5
Fix misleading HTTPS_PROXY wording and example URLs
2 parents 18adb7a + 79a80ed commit bb223e1

File tree

1 file changed

+15
-17
lines changed

1 file changed

+15
-17
lines changed

content/manuals/engine/daemon/proxy.md

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ or using CLI flags for the `--http-proxy` or `--https-proxy` flags for the
4545
{
4646
"proxies": {
4747
"http-proxy": "http://proxy.example.com:3128",
48-
"https-proxy": "https://proxy.example.com:3129",
48+
"https-proxy": "http://proxy.example.com:3128",
4949
"no-proxy": "*.test.example.com,.example.org,127.0.0.0/8"
5050
}
5151
}
@@ -101,21 +101,21 @@ systemd drop-in file that sets the variables for the `docker` service.
101101
Environment="HTTP_PROXY=http://proxy.example.com:3128"
102102
```
103103

104-
If you are behind an HTTPS proxy server, set the `HTTPS_PROXY` environment
104+
To proxy HTTPS requests, set the `HTTPS_PROXY` environment
105105
variable:
106106

107107
```systemd
108108
[Service]
109-
Environment="HTTPS_PROXY=https://proxy.example.com:3129"
109+
Environment="HTTPS_PROXY=http://proxy.example.com:3128"
110110
```
111111

112-
Multiple environment variables can be set; to set both a non-HTTPS and a
113-
HTTPs proxy;
112+
Multiple environment variables can be set; to set both an HTTP and an
113+
HTTPS proxy;
114114

115115
```systemd
116116
[Service]
117117
Environment="HTTP_PROXY=http://proxy.example.com:3128"
118-
Environment="HTTPS_PROXY=https://proxy.example.com:3129"
118+
Environment="HTTPS_PROXY=http://proxy.example.com:3128"
119119
```
120120

121121
> [!NOTE]
@@ -134,7 +134,6 @@ systemd drop-in file that sets the variables for the `docker` service.
134134
The `NO_PROXY` variable specifies a string that contains comma-separated
135135
values for hosts that should be excluded from proxying. These are the options
136136
you can specify to exclude hosts:
137-
138137
- IP address prefix (`1.2.3.4`)
139138
- Domain name, or a special DNS label (`*`)
140139
- A domain name matches that name and all subdomains. A domain name with a
@@ -151,7 +150,7 @@ systemd drop-in file that sets the variables for the `docker` service.
151150
```systemd
152151
[Service]
153152
Environment="HTTP_PROXY=http://proxy.example.com:3128"
154-
Environment="HTTPS_PROXY=https://proxy.example.com:3129"
153+
Environment="HTTPS_PROXY=http://proxy.example.com:3128"
155154
Environment="NO_PROXY=localhost,127.0.0.1,docker-registry.example.com,.corp"
156155
```
157156
@@ -168,7 +167,7 @@ systemd drop-in file that sets the variables for the `docker` service.
168167
```console
169168
$ sudo systemctl show --property=Environment docker
170169

171-
Environment=HTTP_PROXY=http://proxy.example.com:3128 HTTPS_PROXY=https://proxy.example.com:3129 NO_PROXY=localhost,127.0.0.1,docker-registry.example.com,.corp
170+
Environment=HTTP_PROXY=http://proxy.example.com:3128 HTTPS_PROXY=http://proxy.example.com:3128 NO_PROXY=localhost,127.0.0.1,docker-registry.example.com,.corp
172171
```
173172

174173
{{< /tab >}}
@@ -188,21 +187,21 @@ systemd drop-in file that sets the variables for the `docker` service.
188187
Environment="HTTP_PROXY=http://proxy.example.com:3128"
189188
```
190189

191-
If you are behind an HTTPS proxy server, set the `HTTPS_PROXY` environment
190+
To proxy HTTPS requests, set the `HTTPS_PROXY` environment
192191
variable:
193192

194193
```systemd
195194
[Service]
196-
Environment="HTTPS_PROXY=https://proxy.example.com:3129"
195+
Environment="HTTPS_PROXY=http://proxy.example.com:3128"
197196
```
198197

199-
Multiple environment variables can be set; to set both a non-HTTPS and a
200-
HTTPs proxy;
198+
Multiple environment variables can be set; to set both an HTTP and an
199+
HTTPS proxy;
201200

202201
```systemd
203202
[Service]
204203
Environment="HTTP_PROXY=http://proxy.example.com:3128"
205-
Environment="HTTPS_PROXY=https://proxy.example.com:3129"
204+
Environment="HTTPS_PROXY=http://proxy.example.com:3128"
206205
```
207206

208207
> [!NOTE]
@@ -221,7 +220,6 @@ systemd drop-in file that sets the variables for the `docker` service.
221220
The `NO_PROXY` variable specifies a string that contains comma-separated
222221
values for hosts that should be excluded from proxying. These are the options
223222
you can specify to exclude hosts:
224-
225223
- IP address prefix (`1.2.3.4`)
226224
- Domain name, or a special DNS label (`*`)
227225
- A domain name matches that name and all subdomains. A domain name with a
@@ -238,7 +236,7 @@ systemd drop-in file that sets the variables for the `docker` service.
238236
```systemd
239237
[Service]
240238
Environment="HTTP_PROXY=http://proxy.example.com:3128"
241-
Environment="HTTPS_PROXY=https://proxy.example.com:3129"
239+
Environment="HTTPS_PROXY=http://proxy.example.com:3128"
242240
Environment="NO_PROXY=localhost,127.0.0.1,docker-registry.example.com,.corp"
243241
```
244242
@@ -255,7 +253,7 @@ systemd drop-in file that sets the variables for the `docker` service.
255253
```console
256254
$ systemctl --user show --property=Environment docker
257255

258-
Environment=HTTP_PROXY=http://proxy.example.com:3128 HTTPS_PROXY=https://proxy.example.com:3129 NO_PROXY=localhost,127.0.0.1,docker-registry.example.com,.corp
256+
Environment=HTTP_PROXY=http://proxy.example.com:3128 HTTPS_PROXY=http://proxy.example.com:3128 NO_PROXY=localhost,127.0.0.1,docker-registry.example.com,.corp
259257
```
260258

261259
{{< /tab >}}

0 commit comments

Comments
 (0)