Skip to content

Commit d4f6000

Browse files
thaJeztahglours
authored andcommitted
remove import aliases for containerd/errdefs
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 parent c50d16c commit d4f6000

6 files changed

Lines changed: 24 additions & 24 deletions

File tree

pkg/bridge/convert.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import (
2626
"strconv"
2727

2828
"github.com/compose-spec/compose-go/v2/types"
29-
cerrdefs "github.com/containerd/errdefs"
29+
"github.com/containerd/errdefs"
3030
"github.com/docker/cli/cli/command"
3131
cli "github.com/docker/cli/cli/command/container"
3232
"github.com/docker/compose/v2/pkg/api"
@@ -198,7 +198,7 @@ func loadFileObject(conf types.FileObjectConfig) (types.FileObjectConfig, error)
198198

199199
func inspectWithPull(ctx context.Context, dockerCli command.Cli, imageName string) (image.InspectResponse, error) {
200200
inspect, err := dockerCli.Client().ImageInspect(ctx, imageName)
201-
if cerrdefs.IsNotFound(err) {
201+
if errdefs.IsNotFound(err) {
202202
var stream io.ReadCloser
203203
stream, err = dockerCli.Client().ImagePull(ctx, imageName, image.PullOptions{})
204204
if err != nil {

pkg/compose/create.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import (
3030

3131
"github.com/compose-spec/compose-go/v2/paths"
3232
"github.com/compose-spec/compose-go/v2/types"
33-
cerrdefs "github.com/containerd/errdefs"
33+
"github.com/containerd/errdefs"
3434
"github.com/docker/docker/api/types/blkiodev"
3535
"github.com/docker/docker/api/types/container"
3636
"github.com/docker/docker/api/types/filters"
@@ -1262,7 +1262,7 @@ func (s *composeService) ensureNetwork(ctx context.Context, project *types.Proje
12621262
}
12631263

12641264
id, err := s.resolveOrCreateNetwork(ctx, project, name, n)
1265-
if cerrdefs.IsConflict(err) {
1265+
if errdefs.IsConflict(err) {
12661266
// Maybe another execution of `docker compose up|run` created same network
12671267
// let's retry once
12681268
return s.resolveOrCreateNetwork(ctx, project, name, n)
@@ -1497,7 +1497,7 @@ func (s *composeService) resolveExternalNetwork(ctx context.Context, n *types.Ne
14971497
sn, err := s.apiClient().NetworkInspect(ctx, n.Name, network.InspectOptions{})
14981498
if err == nil {
14991499
networks = append(networks, sn)
1500-
} else if !cerrdefs.IsNotFound(err) {
1500+
} else if !errdefs.IsNotFound(err) {
15011501
return "", err
15021502
}
15031503

@@ -1534,7 +1534,7 @@ func (s *composeService) resolveExternalNetwork(ctx context.Context, n *types.Ne
15341534
func (s *composeService) ensureVolume(ctx context.Context, name string, volume types.VolumeConfig, project *types.Project, assumeYes bool) (string, error) {
15351535
inspected, err := s.apiClient().VolumeInspect(ctx, volume.Name)
15361536
if err != nil {
1537-
if !cerrdefs.IsNotFound(err) {
1537+
if !errdefs.IsNotFound(err) {
15381538
return "", err
15391539
}
15401540
if volume.External {

pkg/compose/down.go

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import (
2323
"time"
2424

2525
"github.com/compose-spec/compose-go/v2/types"
26-
cerrdefs "github.com/containerd/errdefs"
26+
"github.com/containerd/errdefs"
2727
"github.com/docker/compose/v2/pkg/api"
2828
"github.com/docker/compose/v2/pkg/progress"
2929
"github.com/docker/compose/v2/pkg/utils"
@@ -219,7 +219,7 @@ func (s *composeService) removeNetwork(ctx context.Context, composeNetworkName s
219219
continue
220220
}
221221
nw, err := s.apiClient().NetworkInspect(ctx, net.ID, network.InspectOptions{})
222-
if cerrdefs.IsNotFound(err) {
222+
if errdefs.IsNotFound(err) {
223223
w.Event(progress.NewEvent(eventName, progress.Warning, "No resource found to remove"))
224224
return nil
225225
}
@@ -233,7 +233,7 @@ func (s *composeService) removeNetwork(ctx context.Context, composeNetworkName s
233233
}
234234

235235
if err := s.apiClient().NetworkRemove(ctx, net.ID); err != nil {
236-
if cerrdefs.IsNotFound(err) {
236+
if errdefs.IsNotFound(err) {
237237
continue
238238
}
239239
w.Event(progress.ErrorEvent(eventName))
@@ -261,11 +261,11 @@ func (s *composeService) removeImage(ctx context.Context, image string, w progre
261261
w.Event(progress.NewEvent(id, progress.Done, "Removed"))
262262
return nil
263263
}
264-
if cerrdefs.IsConflict(err) {
264+
if errdefs.IsConflict(err) {
265265
w.Event(progress.NewEvent(id, progress.Warning, "Resource is still in use"))
266266
return nil
267267
}
268-
if cerrdefs.IsNotFound(err) {
268+
if errdefs.IsNotFound(err) {
269269
w.Event(progress.NewEvent(id, progress.Done, "Warning: No resource found to remove"))
270270
return nil
271271
}
@@ -276,7 +276,7 @@ func (s *composeService) removeVolume(ctx context.Context, id string, w progress
276276
resource := fmt.Sprintf("Volume %s", id)
277277

278278
_, err := s.apiClient().VolumeInspect(ctx, id)
279-
if cerrdefs.IsNotFound(err) {
279+
if errdefs.IsNotFound(err) {
280280
// Already gone
281281
return nil
282282
}
@@ -287,11 +287,11 @@ func (s *composeService) removeVolume(ctx context.Context, id string, w progress
287287
w.Event(progress.NewEvent(resource, progress.Done, "Removed"))
288288
return nil
289289
}
290-
if cerrdefs.IsConflict(err) {
290+
if errdefs.IsConflict(err) {
291291
w.Event(progress.NewEvent(resource, progress.Warning, "Resource is still in use"))
292292
return nil
293293
}
294-
if cerrdefs.IsNotFound(err) {
294+
if errdefs.IsNotFound(err) {
295295
w.Event(progress.NewEvent(resource, progress.Done, "Warning: No resource found to remove"))
296296
return nil
297297
}
@@ -311,7 +311,7 @@ func (s *composeService) stopContainer(
311311
err := s.runHook(ctx, ctr, *service, hook, listener)
312312
if err != nil {
313313
// Ignore errors indicating that some containers were already stopped or removed.
314-
if cerrdefs.IsNotFound(err) || cerrdefs.IsConflict(err) {
314+
if errdefs.IsNotFound(err) || errdefs.IsConflict(err) {
315315
return nil
316316
}
317317
return err
@@ -357,7 +357,7 @@ func (s *composeService) stopAndRemoveContainer(ctx context.Context, ctr contain
357357
w := progress.ContextWriter(ctx)
358358
eventName := getContainerProgressName(ctr)
359359
err := s.stopContainer(ctx, w, service, ctr, timeout, nil)
360-
if cerrdefs.IsNotFound(err) {
360+
if errdefs.IsNotFound(err) {
361361
w.Event(progress.RemovedEvent(eventName))
362362
return nil
363363
}
@@ -369,7 +369,7 @@ func (s *composeService) stopAndRemoveContainer(ctx context.Context, ctr contain
369369
Force: true,
370370
RemoveVolumes: volumes,
371371
})
372-
if err != nil && !cerrdefs.IsNotFound(err) && !cerrdefs.IsConflict(err) {
372+
if err != nil && !errdefs.IsNotFound(err) && !errdefs.IsConflict(err) {
373373
w.Event(progress.ErrorMessageEvent(eventName, "Error while Removing"))
374374
return err
375375
}

pkg/compose/image_pruner.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import (
2323
"sync"
2424

2525
"github.com/compose-spec/compose-go/v2/types"
26-
cerrdefs "github.com/containerd/errdefs"
26+
"github.com/containerd/errdefs"
2727
"github.com/distribution/reference"
2828
"github.com/docker/docker/api/types/filters"
2929
"github.com/docker/docker/api/types/image"
@@ -204,7 +204,7 @@ func (p *ImagePruner) filterImagesByExistence(ctx context.Context, imageNames []
204204
for _, img := range imageNames {
205205
eg.Go(func() error {
206206
_, err := p.client.ImageInspect(ctx, img)
207-
if cerrdefs.IsNotFound(err) {
207+
if errdefs.IsNotFound(err) {
208208
// err on the side of caution: only skip if we successfully
209209
// queried the API and got back a definitive "not exists"
210210
return nil

pkg/compose/images.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import (
2323
"strings"
2424
"sync"
2525

26-
cerrdefs "github.com/containerd/errdefs"
26+
"github.com/containerd/errdefs"
2727
"github.com/containerd/platforms"
2828
"github.com/distribution/reference"
2929
"github.com/docker/docker/api/types/container"
@@ -121,7 +121,7 @@ func (s *composeService) getImageSummaries(ctx context.Context, repoTags []strin
121121
eg.Go(func() error {
122122
inspect, err := s.apiClient().ImageInspect(ctx, repoTag)
123123
if err != nil {
124-
if cerrdefs.IsNotFound(err) {
124+
if errdefs.IsNotFound(err) {
125125
return nil
126126
}
127127
return fmt.Errorf("unable to get image '%s': %w", repoTag, err)

pkg/compose/up.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import (
2525
"syscall"
2626

2727
"github.com/compose-spec/compose-go/v2/types"
28-
cerrdefs "github.com/containerd/errdefs"
28+
"github.com/containerd/errdefs"
2929
"github.com/docker/cli/cli"
3030
"github.com/docker/compose/v2/cmd/formatter"
3131
"github.com/docker/compose/v2/internal/tracing"
@@ -142,7 +142,7 @@ func (s *composeService) Up(ctx context.Context, project *types.Project, options
142142
All: true,
143143
})
144144
// Ignore errors indicating that some of the containers were already stopped or removed.
145-
if cerrdefs.IsNotFound(err) || cerrdefs.IsConflict(err) {
145+
if errdefs.IsNotFound(err) || errdefs.IsConflict(err) {
146146
return nil
147147
}
148148

@@ -220,7 +220,7 @@ func (s *composeService) Up(ctx context.Context, project *types.Project, options
220220
Follow: true,
221221
Since: ctr.State.StartedAt,
222222
})
223-
if cerrdefs.IsNotImplemented(err) {
223+
if errdefs.IsNotImplemented(err) {
224224
// container may be configured with logging_driver: none
225225
// as container already started, we might miss the very first logs. But still better than none
226226
return s.doAttachContainer(ctx, event.Service, event.ID, event.Source, printer.HandleEvent)

0 commit comments

Comments
 (0)