Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Commit 9414246

Browse files
Bumping golang to 1.15.0
Bumping gotestsum to 0.5.2 Temporarily moving e2e tests to go test directly instead of gotestsum as it fails to forward ldflags with go 1.15.0 Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
1 parent 740005f commit 9414246

6 files changed

Lines changed: 16 additions & 15 deletions

File tree

.github/workflows/build-pr.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ jobs:
88
env:
99
GO111MODULE: "on"
1010
steps:
11-
- name: Set up Go 1.14
11+
- name: Set up Go 1.15
1212
uses: actions/setup-go@v1
1313
with:
14-
go-version: 1.14
14+
go-version: 1.15
1515
id: go
1616

1717
- name: Checkout code into the Go module directory
@@ -38,10 +38,10 @@ jobs:
3838
- name: Docker version
3939
run: docker version
4040

41-
- name: Set up Go 1.14
41+
- name: Set up Go 1.15
4242
uses: actions/setup-go@v1
4343
with:
44-
go-version: 1.14
44+
go-version: 1.15
4545
id: go
4646

4747
- name: Checkout code into the Go module directory

.github/workflows/release-weekly-build.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ jobs:
1818
env:
1919
GO111MODULE: "on"
2020
steps:
21-
- name: Set up Go 1.14
21+
- name: Set up Go 1.15
2222
uses: actions/setup-go@v1
2323
with:
24-
go-version: 1.14
24+
go-version: 1.15
2525
id: go
2626

2727
- name: Checkout code into the Go module directory
@@ -53,10 +53,10 @@ jobs:
5353
# Only the CLI is needed to run docker-scan e2e
5454
run: brew install docker
5555

56-
- name: Set up Go 1.14
56+
- name: Set up Go 1.15
5757
uses: actions/setup-go@v2
5858
with:
59-
go-version: 1.14
59+
go-version: 1.15
6060
id: go
6161

6262
- name: Checkout code into the Go module directory

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
# limitations under the License.
1717

1818

19-
ARG GO_VERSION=1.14.6
19+
ARG GO_VERSION=1.15.0
2020
ARG CLI_VERSION=19.03.9
2121
ARG ALPINE_VERSION=3.12.0
2222
ARG GOLANGCI_LINT_VERSION=v1.27.0-alpine
@@ -90,7 +90,7 @@ COPY --from=cross-build /go/src/github.com/docker/scan-cli-plugin/dist /
9090
# GOTESTSUM
9191
####
9292
FROM alpine:${ALPINE_VERSION} AS gotestsum
93-
ARG GOTESTSUM_VERSION=0.4.2
93+
ARG GOTESTSUM_VERSION=0.5.2
9494

9595
RUN apk add -U --no-cache wget tar
9696
# install gotestsum

builder.Makefile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@ e2e:
4848
mkdir -p docker-config/scan
4949
mkdir -p docker-config/cli-plugins
5050
cp ./bin/${PLATFORM_BINARY} docker-config/cli-plugins/${BINARY}
51-
$(VARS) gotestsum ./e2e $(RUN_TEST) -- -ldflags=$(LDFLAGS)
51+
# TODO: gotestsum doesn't forward ldflags to go test with golang 1.15.0, so moving back to go test temporarily
52+
$(VARS) go test ./e2e $(RUN_TEST) -ldflags=$(LDFLAGS)
5253

5354
.PHONY: test-unit
5455
test-unit:
@@ -75,4 +76,4 @@ download:
7576
curl https://github.com/snyk/snyk/releases/download/v${SNYK_DESKTOP_VERSION}/${SNYK_DOWNLOAD_NAME} -L -s -S -o docker-config/snyk-desktop/${SNYK_BINARY}
7677
chmod +x docker-config/snyk-desktop/${SNYK_BINARY}
7778

78-
GO111MODULE=on go get gotest.tools/gotestsum@v0.4.2
79+
GO111MODULE=on go get gotest.tools/gotestsum@v${GOTESTSUM_VERSION}

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/docker/scan-cli-plugin
22

3-
go 1.14
3+
go 1.15
44

55
require (
66
github.com/Azure/go-ansiterm v0.0.0-20170929234023-d6e3b3328b78 // indirect

vars.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
# Pinned Versions
22
SNYK_DESKTOP_VERSION=1.332.0
33
SNYK_USER_VERSION=1.334.0
4-
GO_VERSION=1.14.6
4+
GO_VERSION=1.15.0
55
CLI_VERSION=19.03.9
66
ALPINE_VERSION=3.12.0
77
GOLANGCI_LINT_VERSION=v1.27.0-alpine
8-
GOTESTSUM_VERSION=0.4.2
8+
GOTESTSUM_VERSION=0.5.2
99

1010
GOOS ?= $(shell go env GOOS)
1111
BINARY_EXT=

0 commit comments

Comments
 (0)