Fix Snyk update notification: we erased the env vars using os.Environ() instead of appending to the cmd.Env.

silvin-lubecki · silvin-lubecki · commit 265d37ce4786 · 2020-09-22T10:17:54.000+02:00
Signed-off-by: Silvin Lubecki &lt;silvin.lubecki@docker.com&gt;
diff --git a/internal/provider/snyk.go b/internal/provider/snyk.go
@@ -148,8 +148,9 @@ func (s *snykProvider) Scan(image string) error {
 		if err != nil {
 			return fmt.Errorf("failed to get DockerScanID: %s", err)
 		}
-		cmd.Env = append(os.Environ(), fmt.Sprintf("SNYK_DOCKER_TOKEN=%s", token))
+		cmd.Env = append(cmd.Env, fmt.Sprintf("SNYK_DOCKER_TOKEN=%s", token))
 	}
+
 	cmd.Stdout = os.Stdout
 	cmd.Stderr = os.Stderr
 	return checkCommandErr(cmd.Run())

Original file line number	Diff line number	Diff line change
`@@ -148,8 +148,9 @@ func (s *snykProvider) Scan(image string) error {`
`148`	`148`	`if err != nil {`
`149`	`149`	`return fmt.Errorf("failed to get DockerScanID: %s", err)`
`150`	`150`	`}`
`151`		`- cmd.Env = append(os.Environ(), fmt.Sprintf("SNYK_DOCKER_TOKEN=%s", token))`
	`151`	`+ cmd.Env = append(cmd.Env, fmt.Sprintf("SNYK_DOCKER_TOKEN=%s", token))`
`152`	`152`	`}`
	`153`	`+`
`153`	`154`	`cmd.Stdout = os.Stdout`
`154`	`155`	`cmd.Stderr = os.Stderr`
`155`	`156`	`return checkCommandErr(cmd.Run())`