Remove poll-breaking assertion in e2e test

zappy-shu · zappy-shu · commit c58a1721b714 · 2019-12-12T10:03:26.000Z
Removed assertion of local-in-docker command result when running e2e tests in swarm.
This function is only used by the compatibility tests which does it's own assertion in a poll.
The removed assertion was breaking the poll flow stopping the test from being able to retry.

Signed-off-by: Nick Adcock &lt;nick.adcock@docker.com&gt;
diff --git a/e2e/helper_test.go b/e2e/helper_test.go
@@ -62,7 +62,6 @@ func runWithDindSwarmAndRegistry(t *testing.T, todo func(dindSwarmAndRegistryInf
 		}
 		cmd := icmd.Command(params[0], params[1:]...)
 		result := icmd.RunCmd(cmd)
-		result.Assert(t, icmd.Success)
 		return result.Combined()
 	}
 	// Func to execute docker cli commands

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,6 @@ func runWithDindSwarmAndRegistry(t *testing.T, todo func(dindSwarmAndRegistryInf`
`62`	`62`	`}`
`63`	`63`	`cmd := icmd.Command(params[0], params[1:]...)`
`64`	`64`	`result := icmd.RunCmd(cmd)`
`65`		`- result.Assert(t, icmd.Success)`
`66`	`65`	`return result.Combined()`
`67`	`66`	`}`
`68`	`67`	`// Func to execute docker cli commands`