Eclipse JDT 4.39 seems broken

[blacelle]

Hello,

I try to upgrade Eclipse JDT to 4.39 in mvn configuration but it fails.

<eclipse>
	<version>4.39</version>
	<file>${maven.multiModuleProjectDirectory}/.cleanthat/eclipse_java_code_formatter.xml</file>
</eclipse>

With mvn spotless:apply:

10:55:59,052 [INFO] org.apache.maven.cli.event.ExecutionEventLogger - --- spotless:3.4.0:apply (applySpotless) @ aggregator-adhoc ---
/ERROR WHILE PARSING BELOW
<?xml version='1.0' encoding='UTF-8'?>
<?compositeMetadataRepository version='1.0.0'?>
<repository name='Eclipse 4.39 release' type='org.eclipse.equinox.internal.p2.metadata.repository.CompositeMetadataRepository' version='1'>
  <properties size='3'>
    <property name='p2.atomic.composite.loading' value='true'/>
    <property name='p2.timestamp' value='1764340510951'/>
    <property name='p2.compressed' value='true'/>
  </properties>
</repository>

\ERROR WHILE PARSING ABOVE

...

10:56:00,041 [ERROR] org.apache.maven.cli.MavenCli - Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:3.4.0:apply (applySpotless) on project aggregator-adhoc: Execution applySpotless of goal com.diffplug.spotless:spotless-maven-plugin:3.4.0:apply failed: java.io.IOException: Failed to provision P2 dependencies: Cannot invoke "org.w3c.dom.Node.getChildNodes()" because "childrenNode" is null -> [Help 1]

With -X:

Caused by: java.lang.NullPointerException: Cannot invoke "org.w3c.dom.Node.getChildNodes()" because "childrenNode" is null
    at dev.equo.solstice.p2.P2Client.lambda$parseComposite$1 (P2Client.java:367)
    at dev.equo.solstice.p2.P2Client.parseDocument (P2Client.java:403)
    at dev.equo.solstice.p2.P2Client.parseComposite (P2Client.java:362)
    at dev.equo.solstice.p2.P2Client.addUnits (P2Client.java:107)
    at dev.equo.solstice.p2.P2Session.populateFrom (P2Session.java:34)
    at dev.equo.solstice.p2.P2Model.queryRaw (P2Model.java:107)
    at dev.equo.solstice.p2.P2Model.query (P2Model.java:136)
    at com.diffplug.spotless.extra.P2Provisioner.lambda$createDefault$0 (P2Provisioner.java:61)
    at com.diffplug.spotless.extra.EquoBasedStepBuilder.lambda$build$0 (EquoBasedStepBuilder.java:127)
    at com.diffplug.spotless.JarState$Promised.get (JarState.java:75)
    at com.diffplug.spotless.JarState$Promised.writeObject (JarState.java:88)
    at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:104)
    at java.lang.reflect.Method.invoke (Method.java:565)
    at java.io.ObjectStreamClass.invokeWriteObject (ObjectStreamClass.java:946)
    at java.io.ObjectOutputStream.writeSerialData (ObjectOutputStream.java:1395)
    at java.io.ObjectOutputStream.writeOrdinaryObject (ObjectOutputStream.java:1317)
    at java.io.ObjectOutputStream.writeObject0 (ObjectOutputStream.java:1079)
    at java.io.ObjectOutputStream.defaultWriteFields (ObjectOutputStream.java:1451)
    at java.io.ObjectOutputStream.writeSerialData (ObjectOutputStream.java:1408)
    at java.io.ObjectOutputStream.writeOrdinaryObject (ObjectOutputStream.java:1317)
    at java.io.ObjectOutputStream.writeObject0 (ObjectOutputStream.java:1079)
    at java.io.ObjectOutputStream.defaultWriteFields (ObjectOutputStream.java:1451)
    at java.io.ObjectOutputStream.defaultWriteObject (ObjectOutputStream.java:412)
    at com.diffplug.spotless.FormatterStepSerializationRoundtrip.writeObject (FormatterStepSerializationRoundtrip.java:84)

Though :

• https://download.eclipse.org/eclipse/updates/4.39/ looks fine

Documentation: https://github.com/diffplug/spotless/tree/main/plugin-maven#eclipse-jdt

Thanks

[jhthompson]

I think this might happen because 4.39 wasn't fully released yet (I'm seeing a similar error with 4.40 now). If you try again now with 4.39 it should work?

[blacelle]

The issue remains, and it seems identical.

[blacelle]

(I'm fine with 4.40. I just want something as recent as possible.)

[blacelle]

This is seemingly a cache issue. Dropping ../.m2/repository/dev/equo/p2-data (used as cache for P2 by equo) leads to 4.39 working correctly. 4.40 demonstrates the same NPE, possibly because 4.40 is not released yet. Though, once it will be released, I guess it will require dropping the cache manually.