lint対応

Author: fono09

plugins/hato.py

@@ -9,17 +9,14 @@
 from enum import Enum, auto
 from logging import getLogger
 from tempfile import NamedTemporaryFile
-from typing import List, Callable, Union, Any, TYPE_CHECKING
+from typing import List
 import requests
 from git import Repo
 from git.exc import InvalidGitRepositoryError, GitCommandNotFound
 import pandas as pd
 import matplotlib.pyplot as plt
 import slackbot_settings as conf
 
-if TYPE_CHECKING:
-    from mypy_extensions import VarArg
-
 from library.vocabularydb \
     import get_vocabularys, add_vocabulary, show_vocabulary, \
     delete_vocabulary, show_random_vocabulary
@@ -41,7 +38,7 @@ def action(plugin_name: str, with_client: bool = False):
 
     """
 
-    def _action(func: Callable[[BaseClient, VarArg(Any)], Union[str, None]]):
+    def _action(func):
         def wrapper(client: BaseClient, *args, **kwargs):
             logger.debug("%s called '%s'", client.get_send_user(), plugin_name)
             logger.debug("%s app called '%s'", client.get_type(), plugin_name)

tests/plugins/test_analyze.py

@@ -24,7 +24,8 @@ def test_totuzensi(self):
         client1 = TestClient()
         analyze_message('>< aaa')(client1)
         client2 = TestClient()
-        hato.totuzensi(client2, message='aaa')
+        # pylint: disable=E1121
+        hato.totuzensi(client2, 'aaa')
         self.assertEqual(client1.get_post_message(),
                          client2.get_post_message())
         # self.assertEqual(analyze_message('>< aaa'), hato.totuzensi('aaa'))

tests/plugins/test_hato.py

@@ -76,7 +76,8 @@ def get_amesh_test(self,
         mocker.get(jma_image_url, content=image_content)
         mocker.get(osm_image_url, content=image_content)
         mocker.get(jma_json_url, content=json_content)
-        amesh(client1, place=place)
+        actual = amesh(client1, place=place)
+        self.assertEqual(None, actual)
         return client1
 
     def amesh_upload_png_test(self,
@@ -157,7 +158,9 @@ def altitude_test(self,
         query = '&'.join([f'{k}={v}' for k, v in params.items()])
         mocker.get('https://map.yahooapis.jp/alt/V1/getAltitude?' + query,
                    content=json.dumps(content).encode())
-        altitude(client1, place=place)
+        # pylint: disable=E1121
+        actual = altitude(client1, place)
+        self.assertEqual(None, actual)
         return client1
 
     def test_altitude_with_no_params(self):
@@ -226,6 +229,7 @@ class TestYoshiyoshi(unittest.TestCase):
     def test_yoshiyoshi(self):
         """ 正常系のテストケース """
         client1 = TestClient()
+        # pylint: disable=E1121
         yoshiyoshi(client1)
         self.assertEqual(client1.get_post_message(), 'よしよし')
 
@@ -241,6 +245,7 @@ def test_omikuji(self):
         """
 
         client1 = TestClient()
+        # pylint: disable=E1121
         omikuji(client1)
         self.assertIn(
             client1.get_post_message(),

tests/test_run.py

@@ -23,6 +23,7 @@ def test_telephone_link(self):
         ]
         analyze_slack_message(messages)(client1)
         client2 = TestClient()
+        # pylint: disable=E1121
         hato.totuzensi(client2, '09012345678')
         self.assertEqual(client1.get_post_message(),
                          client2.get_post_message())
@@ -36,6 +37,7 @@ def test_code(self):
         ]
         analyze_slack_message(messages)(client1)
         client2 = TestClient()
+        # pylint: disable=E1121
         hato.totuzensi(client2, '09012345678')
         self.assertEqual(client1.get_post_message(),
                          client2.get_post_message())