Skip to content

Commit a073545

Browse files
committed
Fix merge issues
1 parent 4f67ef2 commit a073545

3 files changed

Lines changed: 25 additions & 17 deletions

File tree

lib/cppcheck.cpp

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1062,16 +1062,18 @@ unsigned int CppCheck::checkInternal(const FileWithDetails& file, const std::str
10621062
std::inserter(configDefines, configDefines.end()),
10631063
getDefineName);
10641064

1065-
preprocessor.setLoadCallback([&](simplecpp::FileData &data) {
1066-
// Do preprocessing on included file
1067-
mLogger->addRemarkComments(preprocessor.getRemarkComments(data.tokens));
1068-
preprocessor.inlineSuppressions(data.tokens, mSuppressions.nomsg);
1069-
Preprocessor::removeComments(data.tokens);
1070-
Preprocessor::createDirectives(data.tokens, directives);
1071-
Preprocessor::simplifyPragmaAsm(data.tokens);
1072-
// Discover new configurations from included file
1073-
if (configurations.size() < maxConfigs)
1074-
preprocessor.getConfigs(data.filename, data.tokens, configDefines, configurations);
1065+
preprocessor.setLoadCallback([&](simplecpp::FileData &data, bool loaded) {
1066+
if (loaded) {
1067+
// Do preprocessing on included file
1068+
mLogger->addRemarkComments(preprocessor.getRemarkComments(data.tokens));
1069+
preprocessor.inlineSuppressions(data.tokens, mSuppressions.nomsg);
1070+
Preprocessor::removeComments(data.tokens);
1071+
Preprocessor::createDirectives(data.tokens, directives);
1072+
Preprocessor::simplifyPragmaAsm(data.tokens);
1073+
// Discover new configurations from included file
1074+
if (configurations.size() < maxConfigs)
1075+
preprocessor.getConfigs(data.filename, data.tokens, configDefines, configurations);
1076+
}
10751077
});
10761078

10771079
preprocessor.setPlatformInfo();

test/testpreprocessor.cpp

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -411,9 +411,11 @@ class TestPreprocessor : public TestFixture {
411411
settings.library.defines().end(),
412412
std::inserter(configDefines, configDefines.end()),
413413
getDefineName);
414-
preprocessor.setLoadCallback([&](simplecpp::FileData &data) {
415-
Preprocessor::removeComments(data.tokens);
416-
preprocessor.getConfigs(data.filename, data.tokens, configDefines, configs);
414+
preprocessor.setLoadCallback([&](simplecpp::FileData &data, bool loaded) {
415+
if (loaded) {
416+
Preprocessor::removeComments(data.tokens);
417+
preprocessor.getConfigs(data.filename, data.tokens, configDefines, configs);
418+
}
417419
});
418420
preprocessor.removeComments();
419421
preprocessor.getConfigs(configDefines, configs);
@@ -430,8 +432,10 @@ class TestPreprocessor : public TestFixture {
430432
std::vector<std::string> files;
431433
simplecpp::TokenList tokens(code,files,"test.c");
432434
Preprocessor preprocessor(tokens, settingsDefault, *this, Standards::Language::C);
433-
preprocessor.setLoadCallback([](simplecpp::FileData &data) {
434-
Preprocessor::removeComments(data.tokens);
435+
preprocessor.setLoadCallback([](simplecpp::FileData &data, bool loaded) {
436+
if (loaded) {
437+
Preprocessor::removeComments(data.tokens);
438+
}
435439
});
436440
preprocessor.removeComments();
437441
ASSERT(preprocessor.loadFiles(files));

test/testtokenize.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -608,8 +608,10 @@ class TestTokenizer : public TestFixture {
608608
simplecpp::TokenList tokens1(code, files, filename, {}, &outputList);
609609
Preprocessor preprocessor(tokens1, settings, *this, Path::identify(tokens1.getFiles()[0], false));
610610
std::list<Directive> directives;
611-
preprocessor.setLoadCallback([&](const simplecpp::FileData &data) {
612-
Preprocessor::createDirectives(data.tokens, directives);
611+
preprocessor.setLoadCallback([&](const simplecpp::FileData &data, bool loaded) {
612+
if (loaded) {
613+
Preprocessor::createDirectives(data.tokens, directives);
614+
}
613615
});
614616
preprocessor.createDirectives(directives);
615617
ASSERT(preprocessor.loadFiles(files));

0 commit comments

Comments
 (0)