refactor: update shebang and improve pattern matching in scripts

- Changed the shebang in `gtr.bash` and `generate-completions.sh` to use `/usr/bin/env bash` for better portability.
- Refactored pattern matching logic in `copy.sh` to utilize a case statement, enhancing readability and maintainability.
- Added a local variable declaration in `create.sh` for improved clarity in the command execution flow.
- Updated conditional checks in `go.sh` and `run.sh` to use quotes around array length checks, preventing potential errors.

Author: helizaga

completions/gtr.bash

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # AUTO-GENERATED by scripts/generate-completions.sh — DO NOT EDIT MANUALLY
 # Re-generate with: ./scripts/generate-completions.sh
 #

lib/commands/create.sh

@@ -169,6 +169,7 @@ cmd_create() {
   echo "Branch: $branch_name"
 
   # Create the worktree
+  local worktree_path
   if ! worktree_path=$(create_worktree "$base_dir" "$prefix" "$branch_name" "$from_ref" "$track_mode" "$skip_fetch" "$force" "$custom_name" "$folder_override"); then
     exit 1
   fi

lib/commands/go.sh

@@ -5,7 +5,7 @@
 cmd_go() {
   parse_args "" "$@"
 
-  if [ ${#_pa_positional[@]} -ne 1 ]; then
+  if [ "${#_pa_positional[@]}" -ne 1 ]; then
     log_error "Usage: git gtr go <id|branch>"
     exit 1
   fi

lib/commands/rename.sh

@@ -76,7 +76,7 @@ cmd_rename() {
     move_args+=(--force)
   fi
 
-  if ! git -C "$repo_root" worktree move "$old_path" "$new_path" "${move_args[@]}"; then
+  if ! git -C "$repo_root" worktree move "${move_args[@]}" "$old_path" "$new_path"; then
     # Rollback: rename branch back
     log_warn "Worktree move failed, rolling back branch rename..."
     git -C "$repo_root" branch -m "$new_name" "$old_branch" 2>/dev/null || true

lib/commands/run.sh

@@ -47,7 +47,7 @@ cmd_run() {
     exit 1
   fi
 
-  if [ ${#run_args[@]} -eq 0 ]; then
+  if [ "${#run_args[@]}" -eq 0 ]; then
     log_error "Usage: git gtr run <id|branch> <command...>"
     log_error "No command specified"
     exit 1

lib/copy.sh

@@ -320,7 +320,7 @@ copy_directories() {
         log_warn "Failed to copy directory $dir_path"
       fi
     done <<EOF
-$(if [[ "$pattern" == */* ]]; then find . -type d -path "./$pattern" 2>/dev/null; else find . -type d -name "$pattern" 2>/dev/null; fi || true)
+$(case "$pattern" in */*) find . -type d -path "./$pattern" 2>/dev/null ;; *) find . -type d -name "$pattern" 2>/dev/null ;; esac)
 EOF
   done <<EOF
 $dir_patterns

scripts/generate-completions.sh

@@ -88,7 +88,7 @@ CONFIG_KEYS=$(get_config_keys)
 
 generate_bash() {
   cat <<'HEADER'
-#!/bin/bash
+#!/usr/bin/env bash
 # AUTO-GENERATED by scripts/generate-completions.sh — DO NOT EDIT MANUALLY
 # Re-generate with: ./scripts/generate-completions.sh
 #