chore: use constant for n/a action string

Author: bakito

pkg/http/postserver-event.go

@@ -16,6 +16,8 @@ func (s *PostServer) postEvent(ctx *gin.Context) {
 	processPostedEvent(ctx, s.Server, s.postEventCallback)
 }
 
+const eventActionNotAvailable = "n/a"
+
 func (s *PostServer) postEventCallback(ctx *gin.Context, postLog logr.Logger, podName string, event *Event) error {
 	pod := &corev1.Pod{}
 	err := s.Client.Get(ctx, client.ObjectKey{Namespace: s.Config.Namespace, Name: podName}, pod)
@@ -28,7 +30,7 @@ func (s *PostServer) postEventCallback(ctx *gin.Context, postLog logr.Logger, po
 
 	action := event.Action
 	if action == "" {
-		action = "N/A"
+		action = eventActionNotAvailable
 	}
 
 	if len(event.Args) > 0 {

pkg/http/postserver_test.go

@@ -304,7 +304,7 @@ var _ = Describe("HTTP", func() {
 			mockSink.EXPECT().WithValues("node", node, "id", executionID).Return(mockSink)
 			mockSink.EXPECT().WithValues("length", gm.Any()).Return(mockSink)
 			mockSink.EXPECT().WithValues("pod", gm.Any(), "type", "Warning", "reason", "TestReason", "event-message", "test message: a1").Return(mockSink)
-			mockRecord.EXPECT().Eventf(gm.Any(), gm.Any(), "Warning", "TestReason", "N/A", "test message: %s", "a1")
+			mockRecord.EXPECT().Eventf(gm.Any(), gm.Any(), "Warning", "TestReason", eventActionNotAvailable, "test message: %s", "a1")
 			mockSink.EXPECT().Info(gm.Any(), "event created")
 			mockReader.EXPECT().
 				Get(gm.Any(), client.ObjectKey{Namespace: s.Config.Namespace, Name: s.Config.PodName(node, executionID)}, gm.AssignableToTypeOf(&corev1.Pod{}))