Skip to content

Commit f913149

Browse files
authored
chore: move read write splitting files into a read_write_splitting directory (#609)
1 parent d59771f commit f913149

7 files changed

Lines changed: 69 additions & 69 deletions

common/lib/connection_plugin_chain_builder.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import { FailoverPluginFactory } from "./plugins/failover/failover_plugin_factor
2929
import { Failover2PluginFactory } from "./plugins/failover2/failover2_plugin_factory";
3030
import { StaleDnsPluginFactory } from "./plugins/stale_dns/stale_dns_plugin_factory";
3131
import { FederatedAuthPluginFactory } from "./plugins/federated_auth/federated_auth_plugin_factory";
32-
import { ReadWriteSplittingPluginFactory } from "./plugins/read_write_splitting_plugin_factory";
32+
import { ReadWriteSplittingPluginFactory } from "./plugins/read_write_splitting/read_write_splitting_plugin_factory";
3333
import { OktaAuthPluginFactory } from "./plugins/federated_auth/okta_auth_plugin_factory";
3434
import { HostMonitoringPluginFactory } from "./plugins/efm/host_monitoring_plugin_factory";
3535
import { AuroraInitialConnectionStrategyFactory } from "./plugins/aurora_initial_connection_strategy_plugin_factory";

common/lib/plugins/read_write_splitting_plugin.ts renamed to common/lib/plugins/read_write_splitting/read_write_splitting_plugin.ts

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,37 @@
11
/*
2-
Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
3-
4-
Licensed under the Apache License, Version 2.0 (the "License").
5-
You may not use this file except in compliance with the License.
6-
You may obtain a copy of the License at
7-
8-
http://www.apache.org/licenses/LICENSE-2.0
9-
10-
Unless required by applicable law or agreed to in writing, software
11-
distributed under the License is distributed on an "AS IS" BASIS,
12-
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13-
See the License for the specific language governing permissions and
14-
limitations under the License.
15-
*/
16-
17-
import { AbstractConnectionPlugin } from "../abstract_connection_plugin";
2+
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License").
5+
* You may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
import { AbstractConnectionPlugin } from "../../abstract_connection_plugin";
1818
import {
1919
HostInfo,
2020
FailoverError,
2121
HostRole
22-
} from "../";
23-
import { PluginService } from "../plugin_service";
24-
import { HostListProviderService } from "../host_list_provider_service";
25-
import { OldConnectionSuggestionAction } from "../old_connection_suggestion_action";
26-
import { HostChangeOptions } from "../host_change_options";
27-
import { WrapperProperties } from "../wrapper_property";
28-
import { Messages } from "../utils/messages";
29-
import { logger } from "../../logutils";
30-
import { SqlMethodUtils } from "../utils/sql_method_utils";
31-
import { ClientWrapper } from "../client_wrapper";
32-
import { getWriter, logAndThrowError } from "../utils/utils";
33-
import { CanReleaseResources } from "../can_release_resources";
34-
import { PoolClientWrapper } from "../pool_client_wrapper";
22+
} from "../../index";
23+
import { PluginService } from "../../plugin_service";
24+
import { HostListProviderService } from "../../host_list_provider_service";
25+
import { OldConnectionSuggestionAction } from "../../old_connection_suggestion_action";
26+
import { HostChangeOptions } from "../../host_change_options";
27+
import { WrapperProperties } from "../../wrapper_property";
28+
import { Messages } from "../../utils/messages";
29+
import { logger } from "../../../logutils";
30+
import { SqlMethodUtils } from "../../utils/sql_method_utils";
31+
import { ClientWrapper } from "../../client_wrapper";
32+
import { getWriter, logAndThrowError } from "../../utils/utils";
33+
import { CanReleaseResources } from "../../can_release_resources";
34+
import { PoolClientWrapper } from "../../pool_client_wrapper";
3535

3636
export class ReadWriteSplittingPlugin extends AbstractConnectionPlugin implements CanReleaseResources {
3737
private static readonly subscribedMethods: Set<string> = new Set(["initHostProvider", "connect", "notifyConnectionChanged", "query"]);
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/*
2+
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License").
5+
* You may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
import { ConnectionPluginFactory } from "../../plugin_factory";
18+
import { PluginService } from "../../plugin_service";
19+
import { ConnectionPlugin } from "../../connection_plugin";
20+
import { AwsWrapperError } from "../../utils/errors";
21+
import { Messages } from "../../utils/messages";
22+
23+
export class ReadWriteSplittingPluginFactory extends ConnectionPluginFactory {
24+
private static readWriteSplittingPlugin: any;
25+
26+
async getInstance(pluginService: PluginService, properties: Map<string, any>): Promise<ConnectionPlugin> {
27+
try {
28+
if (!ReadWriteSplittingPluginFactory.readWriteSplittingPlugin) {
29+
ReadWriteSplittingPluginFactory.readWriteSplittingPlugin = await import("./read_write_splitting_plugin");
30+
}
31+
return new ReadWriteSplittingPluginFactory.readWriteSplittingPlugin.ReadWriteSplittingPlugin(pluginService, properties);
32+
} catch (error: any) {
33+
throw new AwsWrapperError(Messages.get("ConnectionPluginChainBuilder.errorImportingPlugin", error.message, "readWriteSplittingPlugin"));
34+
}
35+
}
36+
}

common/lib/plugins/read_write_splitting_plugin_factory.ts

Lines changed: 0 additions & 36 deletions
This file was deleted.

common/lib/profile/driver_configuration_profiles.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import { WrapperProperties } from "../wrapper_property";
2020
import { HostMonitoringPluginFactory } from "../plugins/efm/host_monitoring_plugin_factory";
2121
import { AuroraInitialConnectionStrategyFactory } from "../plugins/aurora_initial_connection_strategy_plugin_factory";
2222
import { AuroraConnectionTrackerPluginFactory } from "../plugins/connection_tracker/aurora_connection_tracker_plugin_factory";
23-
import { ReadWriteSplittingPluginFactory } from "../plugins/read_write_splitting_plugin_factory";
23+
import { ReadWriteSplittingPluginFactory } from "../plugins/read_write_splitting/read_write_splitting_plugin_factory";
2424
import { FailoverPluginFactory } from "../plugins/failover/failover_plugin_factory";
2525
import { InternalPooledConnectionProvider } from "../internal_pooled_connection_provider";
2626
import { AwsPoolConfig } from "../aws_pool_config";

index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export { ConnectTimePlugin } from "./common/lib/plugins/connect_time_plugin";
2727
export { ExecuteTimePlugin } from "./common/lib/plugins/execute_time_plugin";
2828
export { AuroraInitialConnectionStrategyPlugin } from "./common/lib/plugins/aurora_initial_connection_strategy_plugin";
2929
export { DefaultPlugin } from "./common/lib/plugins/default_plugin";
30-
export { ReadWriteSplittingPlugin } from "./common/lib/plugins/read_write_splitting_plugin";
30+
export { ReadWriteSplittingPlugin } from "./common/lib/plugins/read_write_splitting/read_write_splitting_plugin";
3131
export { FailoverPlugin } from "./common/lib/plugins/failover/failover_plugin";
3232
export { Failover2Plugin } from "./common/lib/plugins/failover2/failover2_plugin";
3333
export { HostMonitoringConnectionPlugin } from "./common/lib/plugins/efm/host_monitoring_connection_plugin";

tests/unit/read_write_splitting.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import { PluginServiceImpl } from "../../common/lib/plugin_service";
2929
import { AwsMySQLClient } from "../../mysql/lib";
3030
import { anything, instance, mock, reset, spy, verify, when } from "ts-mockito";
3131
import { HostListProviderService } from "../../common/lib/host_list_provider_service";
32-
import { ReadWriteSplittingPlugin } from "../../common/lib/plugins/read_write_splitting_plugin";
32+
import { ReadWriteSplittingPlugin } from "../../common/lib/plugins/read_write_splitting/read_write_splitting_plugin";
3333
import { SimpleHostAvailabilityStrategy } from "../../common/lib/host_availability/simple_host_availability_strategy";
3434
import { MySQLDatabaseDialect } from "../../mysql/lib/dialect/mysql_database_dialect";
3535
import { HostChangeOptions } from "../../common/lib/host_change_options";

0 commit comments

Comments
 (0)