fix(@angular/cli): use spawn with args array on Windows and remove manual quoting tests

Author: Tednoob17

packages/angular/cli/src/commands/add/registry-validation.spec.ts

@@ -22,8 +22,8 @@ describe('registry validation', () => {
 
     it('should not match safe URL characters', () => {
       expect(SHELL_METACHARACTERS.test('https://registry.example.com')).toBe(false);
-      expect(SHELL_METACHARACTERS.test('http://registry.example.com/path')).toBe(false);
-      expect(SHELL_METACHARACTERS.test('https://registry.example.com:8080')).toBe(false);
+      expect(SHELL_METACHARACTERS.test('http://registry.example.com:8080')).toBe(false);
+      expect(SHELL_METACHARACTERS.test('https://registry.example.com/path')).toBe(false);
     });
   });
 
@@ -61,28 +61,4 @@ describe('registry validation', () => {
       );
     });
   });
-
-  describe('Windows shell quoting', () => {
-    it('should wrap args in double quotes', () => {
-      const command = 'npm';
-      const args = ['--registry', 'https://registry.example.com'];
-      const result = `${command} ${args
-        .map((a) => `"${String(a).replace(/"/g, '\\"')}"`)
-        .join(' ')}`;
-      expect(result).toBe(
-        'npm "--registry" "https://registry.example.com"',
-      );
-    });
-
-    it('should escape inner double quotes', () => {
-      const command = 'npm';
-      const args = ['--registry', 'https://example.com?key="value"'];
-      const result = `${command} ${args
-        .map((a) => `"${String(a).replace(/"/g, '\\"')}"`)
-        .join(' ')}`;
-      expect(result).toBe(
-        'npm "--registry" "https://example.com?key=\\"value\\""',
-      );
-    });
-  });
 });

packages/angular/cli/src/package-managers/host.ts

@@ -157,12 +157,7 @@ export const NodeJS_HOST: Host = {
         cwd: options.cwd,
         env,
       } satisfies SpawnOptions;
-      const childProcess = isWin32
-        ? spawn(
-            `${command} ${args.map((a) => `"${String(a).replace(/"/g, '\\"')}"`).join(' ')}`,
-            spawnOptions,
-          )
-        : spawn(command, args, spawnOptions);
+      const childProcess = spawn(command, args, spawnOptions);
 
       let stdout = '';
       childProcess.stdout?.on('data', (data) => (stdout += data.toString()));