Skip to content

Undocumented API change in V5 #248

Description

@Titozzz

01b0649 breaks the expectation that the callback will be called (with undefined or more) so it's an undocumented breaking API change.

Example code that this change breaks:

  const updateValues = useCallback(() => {
    Adjust.getAdid((id) => {
      setAdid(id ?? '');
    });
    Adjust.getIdfa((id) => {
      setIdfa(id ?? '');
    });
    Adjust.getGoogleAdId((id) => {
      setGpsAdid(id ?? '');
    });
  }, []);

  useEffect(() => {
    updateValues();
  }, [updateValues]);
.....
  if (adid === undefined || gpsAdid === undefined || idfa === undefined) {
    return null;
  }
....
 return meaningful content

Not asking for revert of anything but please be mindful of changes and document them 🤗

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions