Fix after review

Author: guillaume-dequenne

tests/test_configuration_loader.py

@@ -17,7 +17,7 @@
 # along with this program; if not, write to the Free Software Foundation,
 # Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
 #
-
+import os
 from unittest.mock import patch
 
 import pyfakefs.fake_filesystem_unittest as pyfakefs
@@ -26,6 +26,7 @@
 from pysonar_scanner.configuration.properties import (
     SONAR_PROJECT_KEY,
     SONAR_PROJECT_NAME,
+    SONAR_PROJECT_BASE_DIR,
     SONAR_SCANNER_APP,
     SONAR_SCANNER_APP_VERSION,
     SONAR_SCANNER_BOOTSTRAP_START_TIME,
@@ -49,7 +50,7 @@
     SONAR_SCANNER_ARCH,
     SONAR_SCANNER_OS,
 )
-from pysonar_scanner.configuration.configuration_loader import ConfigurationLoader, SONAR_PROJECT_BASE_DIR
+from pysonar_scanner.configuration.configuration_loader import ConfigurationLoader
 from pysonar_scanner.exceptions import MissingKeyException
 from pysonar_scanner.utils import Arch, Os
 
@@ -98,11 +99,15 @@ def test_no_defaults_in_configuration_loaders(
     @patch("pysonar_scanner.configuration.configuration_loader.get_static_default_properties", return_value={})
     @patch("sys.argv", ["myscript.py"])
     def test_dynamic_defaults_are_loaded(self, get_static_default_properties_mock, mock_get_os, mock_get_arch):
+        custom_dir = "/my_analysis_directory"
+        self.fs.create_dir(custom_dir)
+        os.chdir(custom_dir)
         config = ConfigurationLoader.load()
+
         self.assertDictEqual(
             config,
             {
-                SONAR_PROJECT_BASE_DIR: "/",
+                SONAR_PROJECT_BASE_DIR: "/my_analysis_directory",
                 SONAR_SCANNER_OS: Os.LINUX.value,
                 SONAR_SCANNER_ARCH: Arch.X64.value,
             },