Further fix after review

Author: guillaume-dequenne

tests/sq_api_utils.py

@@ -80,13 +80,16 @@ def mock_analysis_jres(
         self,
         body: Optional[list[dict]] = None,
         status: int = 200,
+        os_matcher: Optional[str] = "linux",
+        arch_matcher: Optional[str] = "x86_64",
     ) -> responses.BaseResponse:
         return self.rsps.get(
             url=f"{self.api_url}/analysis/jres",
             json=body,
             status=status,
             match=[
                 matchers.header_matcher({"Accept": "application/json"}),
+                matchers.query_param_matcher(utils.filter_none_values({"os": os_matcher, "arch": arch_matcher})),
             ],
         )
 

tests/test_api.py

@@ -317,12 +317,19 @@ def test_get_analysis_jres(self):
             ),
         ]
 
-        with self.subTest("get_analysis_jres works"), sq_api_mocker() as mocker:
+        with self.subTest("get_analysis_jres works (linux)"), sq_api_mocker() as mocker:
             mocker.mock_analysis_jres([sq_api_utils.jre_to_dict(jre) for jre in expected_jres])
 
             actual_jres = self.sq.get_analysis_jres(os="linux", arch="x86_64")
             self.assertEqual(actual_jres, expected_jres)
 
+        with self.subTest("get_analysis_jres works (windows)"), sq_api_mocker() as mocker:
+            mocker.mock_analysis_jres(
+                [sq_api_utils.jre_to_dict(jre) for jre in expected_jres], os_matcher="windows", arch_matcher="x86"
+            )
+            actual_jres = self.sq.get_analysis_jres(os="windows", arch="x86")
+            self.assertEqual(actual_jres, expected_jres)
+
         with (
             self.subTest("get_analysis_jres returns error"),
             sq_api_mocker() as mocker,