SCANPY-237 Removed redundancy in the output (validation results in dry run mode)

Author: marc-jasper-sonarsource

src/pysonar_scanner/dry_run_reporter.py

@@ -92,8 +92,10 @@ def report_validation_results(validation_result: "ValidationResult") -> int:
         logging.info("=" * 80)
 
         if validation_result.is_valid():
+            for info in validation_result.infos:
+                logging.info(f"✓ {info}")
             for warning in validation_result.warnings:
-                logging.warning(f"  • {warning}")
+                logging.warning(f"• {warning}")
             logging.info("✓ Configuration validation PASSED")
             logging.info("=" * 80)
             return 0
@@ -130,6 +132,7 @@ class ValidationResult:
     def __init__(self):
         self.errors: list[str] = []
         self.warnings: list[str] = []
+        self.infos: list[str] = []
 
     def add_error(self, message: str) -> None:
         """Add a validation error."""
@@ -139,6 +142,10 @@ def add_warning(self, message: str) -> None:
         """Add a validation warning."""
         self.warnings.append(message)
 
+    def add_info(self, message: str) -> None:
+        """Add a validation info message."""
+        self.infos.append(message)
+
     def is_valid(self) -> bool:
         """Check if validation passed (no errors)."""
         return len(self.errors) == 0
@@ -197,7 +204,7 @@ def _validate_single_report(report_path: str, base_path: Path, validation_result
                         f"Coverage report root element is '{root.tag}', expected 'coverage' (Cobertura format)"
                     )
                 else:
-                    logging.info(f"  ✓ Coverage report is valid Cobertura XML: {report_path}")
+                    validation_result.add_info(f"Coverage report is valid Cobertura XML: {report_path}")
         except PermissionError:
             validation_result.add_error(f"Coverage report is not readable (permission denied): {report_path}")
         except UnicodeDecodeError:

tests/unit/test_dry_run.py

@@ -172,9 +172,8 @@ def test_validate_single_report_valid_cobertura(self, mock_logging):
 
         assert result.is_valid()
         assert len(result.warnings) == 0
-        logged_messages = [str(c) for c in mock_logging.info.call_args_list]
-        joined = " ".join(logged_messages)
-        assert "valid Cobertura XML" in joined
+        assert len(result.infos) == 1
+        assert "valid Cobertura XML" in result.infos[0]
 
     def test_validate_multiple_coverage_reports(self):
         self.fs.create_dir("/project")