JS-1493 Fix open SonarCloud maintainability issues (#6642)

Author: zglicz

packages/jsts/src/rules/S1192/rule.ts

@@ -54,7 +54,7 @@ export const rule: Rule.RuleModule = {
       ...DEFAULT_OPTIONS,
       ...(context.options as FromSchema<typeof meta.schema>)[0],
     };
-    const whitelist = ignoreStrings.split(',');
+    const whitelist = new Set(ignoreStrings.split(','));
     return {
       Literal: (node: estree.Node) => {
         const literal = node as TSESTree.Literal;
@@ -67,7 +67,7 @@ export const rule: Rule.RuleModule = {
           const stringContent = literal.value.trim();
 
           if (
-            !whitelist.includes(literal.value) &&
+            !whitelist.has(literal.value) &&
             !isExcludedByUsageContext(context, literal) &&
             stringContent.length >= MIN_LENGTH &&
             !NO_SEPARATOR_REGEXP.test(stringContent)

packages/jsts/src/rules/S134/config.ts

@@ -22,7 +22,7 @@ export const fields = [
   [
     {
       field: 'maximumNestingLevel',
-      description: `Maximum allowed \\"if/for/while/switch/try\\" statements nesting depth`,
+      description: 'Maximum allowed "if/for/while/switch/try" statements nesting depth',
       default: 3,
     },
   ],

packages/jsts/src/rules/S139/config.ts

@@ -23,7 +23,7 @@ export const fields = [
     {
       field: 'ignorePattern',
       description: 'Pattern (JavaScript syntax) for text of trailing comments that are allowed.',
-      default: `^\\s*[^\\s]+$`,
+      default: String.raw`^\s*[^\s]+$`,
       displayName: 'pattern',
     },
   ],

packages/jsts/src/rules/S3776/rule.ts

@@ -372,7 +372,7 @@ export const rule: Rule.RuleModule = {
           if (
             current.operator !== '||' &&
             current.operator !== '??' &&
-            (!previous || previous.operator !== current.operator)
+            previous?.operator !== current.operator
           ) {
             const operatorTokenLoc = getFirstTokenAfter(
               current.left,

packages/jsts/src/rules/S3782/rule.ts

@@ -36,7 +36,7 @@ export const rule: Rule.RuleModule = {
 
     function isBuiltInMethod(symbol: ts.Symbol) {
       const parent = symbol.valueDeclaration?.parent;
-      if (!parent || parent.kind !== ts.SyntaxKind.InterfaceDeclaration) {
+      if (parent?.kind !== ts.SyntaxKind.InterfaceDeclaration) {
         return false;
       }
       const parentSymbol = tc.getSymbolAtLocation((parent as ts.InterfaceDeclaration).name);

packages/jsts/src/rules/S4158/rule.ts

@@ -199,7 +199,7 @@ function isForIterationPattern(ref: Scope.Reference) {
     n => n.type === 'ForOfStatement' || n.type === 'ForInStatement',
   ) as TSESTree.ForOfStatement | TSESTree.ForInStatement;
 
-  return forInOrOfStatement && forInOrOfStatement.right === ref.identifier;
+  return forInOrOfStatement?.right === ref.identifier;
 }
 
 function isElementRead(ref: Scope.Reference) {

packages/jsts/src/rules/S6486/rule.ts

@@ -39,7 +39,7 @@ export const rule: Rule.RuleModule = {
         const node = pNode as unknown as TSESTree.JSXAttribute;
 
         const value = node.value;
-        if (!value || value.type !== 'JSXExpressionContainer') {
+        if (value?.type !== 'JSXExpressionContainer') {
           // key='foo' or just simply 'key'
           return;
         }

packages/jsts/src/rules/helpers/module.ts

@@ -75,7 +75,7 @@ export function isRequire(node: Node): node is estree.CallExpression {
  */
 function getModuleNameFromRequire(node: Node): estree.Literal | undefined {
   if (isRequire(node)) {
-    const moduleName = (node as estree.CallExpression).arguments[0];
+    const moduleName = node.arguments[0];
     if (moduleName.type === 'Literal') {
       return moduleName;
     }

packages/jsts/tests/tools/testers/comment-based/helpers/locations.ts

@@ -23,23 +23,23 @@ export const LINE_ADJUSTMENT = String.raw`(?:@(?<lineAdjustment>(?<relativeAdjus
 const STARTS_WITH_LOCATION = /^ *\^/;
 const COUNT = String.raw`(?<count>\d+)`;
 const DIRECTION = '(?<direction>[<>])';
-const MESSAGE = '(?<message>.*?)';
+const MESSAGE_CONTENT = String.raw`(?:(?!\}\}(?!\})).)*`;
 const LOCATION_PATTERN = new RegExp(
-  ' *' +
+  String.raw`^ *` +
     // highlighted range, ex: ^^^^ |OR| ^^^@12 |OR| ^^^@-2
-    '(?<range>\\^(?:\\[(?<params>[^\\]]+)\\]|\\^+)?)' +
+    String.raw`(?<range>\^(?:\[(?<params>[^\]]+)\]|\^+)?)` +
     LINE_ADJUSTMENT +
     // count, ex: 3 |OR| direction
-    ' *(?:' +
+    String.raw` *(?:` +
     COUNT +
-    '|' +
+    String.raw`|` +
     DIRECTION +
-    ')?' +
+    String.raw`)?` +
     // message, ex: {{msg}}
-    ' *(?:\\{\\{' +
-    MESSAGE +
-    '\\}\\})? *' +
-    '(?:\r(\n?)|\n)?',
+    String.raw` *(?:\{\{` +
+    String.raw`(?<message>${MESSAGE_CONTENT})` +
+    String.raw`\}\})? *` +
+    String.raw`(?:\r?\n)?`,
 );
 
 export abstract class Location {

packages/jsts/tests/tools/testers/comment-based/helpers/quickfixes.ts

@@ -16,33 +16,35 @@
  */
 import { LineIssues } from './issues.js';
 import { Comment } from './comments.js';
-import { extractEffectiveLine, LINE_ADJUSTMENT } from './locations.js';
+import { extractEffectiveLine } from './locations.js';
 
 const STARTS_WITH_QUICKFIX = /^ *(edit|del|add|fix)@/;
-export const QUICKFIX_SEPARATOR = '[,\\s]+';
-export const QUICKFIX_ID =
-  '\\[\\[(?<quickfixes>\\w+(=\\d+)?!?(?:' + QUICKFIX_SEPARATOR + '(?:\\w+(=\\d+)?!?))*)\\]\\]';
+export const QUICKFIX_SEPARATOR = String.raw`[,\s]+`;
+export const QUICKFIX_ID = String.raw`\[\[(?<quickfixes>\w+(=\d+)?!?(?:${QUICKFIX_SEPARATOR}(?:\w+(=\d+)?!?))*)\]\]`;
+const BRACED_TEXT_CONTENT = String.raw`(?:(?!\}\}(?!\})).)*`;
+// Legacy fixtures support line adjustments both as `@+1` and `+1`.
+const QUICKFIX_LINE_ADJUSTMENT = String.raw`(?:@?(?<lineAdjustment>(?<relativeAdjustment>[+-])?\d+))?`;
 const QUICKFIX_DESCRIPTION_PATTERN = new RegExp(
-  ' *' +
+  String.raw`^ *` +
     // quickfix description, ex: fix@qf1 {{Replace with foo}}
-    'fix@(?<quickfixId>\\w+)' +
+    String.raw`fix@(?<quickfixId>\w+)` +
     // message, ex: {{msg}}
-    ' *(?:\\{\\{(?<message>.*?)\\}\\}(?!\\}))? *' +
-    '(?:\\r(\\n?)|\\n)?',
+    String.raw` *(?:\{\{(?<message>${BRACED_TEXT_CONTENT})\}\}(?!\}))? *` +
+    String.raw`(?:\r?\n)?$`,
 );
 
 const QUICKFIX_CHANGE_PATTERN = new RegExp(
-  ' *' +
+  String.raw`^ *` +
     // quickfix edit, ex: edit@qf1
-    '(?<type>edit|add|del)@(?<quickfixId>\\w+)' +
-    LINE_ADJUSTMENT +
+    String.raw`(?<type>edit|add|del)@(?<quickfixId>\w+)` +
+    QUICKFIX_LINE_ADJUSTMENT +
     // start and end columns, ex: [[sc=1;ec=5]] both are optional
-    ' *(?:\\[\\[' +
-    '(?<firstColumnType>sc|ec)=(?<firstColumnValue>\\d+)(?:;(?<secondColumnType>sc|ec)=(?<secondColumnValue>\\d+))?' +
-    '\\]\\])?' +
+    String.raw` *(?:\[\[` +
+    String.raw`(?<firstColumnType>sc|ec)=(?<firstColumnValue>\d+)(?:;(?<secondColumnType>sc|ec)=(?<secondColumnValue>\d+))?` +
+    String.raw`\]\])?` +
     // contents to be applied, ex: {{foo}}
-    ' *(?:\\{\\{(?<contents>.*?)\\}\\}(?!\\}))?' +
-    ' *(?:\\r(\\n?)|\\n)?',
+    String.raw` *(?:\{\{(?<contents>${BRACED_TEXT_CONTENT})\}\}(?!\}))?` +
+    String.raw` *(?:\r?\n)?$`,
 );
 
 type ChangeType = 'add' | 'del' | 'edit';