JS-1606 Fix/reduce issues (#6836)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Author: guillemsarda

packages/analysis/src/css/analysis/metrics.ts

@@ -80,8 +80,8 @@ export function computeMetrics(root: Root | Document): CssMetrics {
   // so line numbers are not necessarily added in order (e.g. a rule's closing
   // brace line is added before its children's lines).
   return {
-    ncloc: Array.from(codeLines).sort((a, b) => a - b),
-    commentLines: Array.from(commentCandidates).sort((a, b) => a - b),
-    nosonarLines: nosonarLines.sort((a, b) => a - b),
+    ncloc: Array.from(codeLines).toSorted((a, b) => a - b),
+    commentLines: Array.from(commentCandidates).toSorted((a, b) => a - b),
+    nosonarLines: nosonarLines.toSorted((a, b) => a - b),
   };
 }

packages/analysis/src/jsts/rules/README.md

@@ -138,7 +138,7 @@ If you have any questions, encounter any bugs, or have feature requests, please
 | [aws-s3-bucket-public-access](https://sonarsource.github.io/rspec/#/rspec/S6281/javascript)          | Allowing public ACLs or policies on a S3 bucket is security-sensitive                                                          | ✅  |     |     |     |     |
 | [aws-s3-bucket-server-encryption](https://sonarsource.github.io/rspec/#/rspec/S6245/javascript)      | Disabling server-side encryption of S3 buckets is security-sensitive                                                           |     |     |     |     | ❌  |
 | [aws-s3-bucket-versioning](https://sonarsource.github.io/rspec/#/rspec/S6252/javascript)             | Disabling versioning of S3 buckets is security-sensitive                                                                       | ✅  |     |     |     |     |
-| [aws-sagemaker-unencrypted-notebook](https://sonarsource.github.io/rspec/#/rspec/S6319/javascript)   | Using unencrypted SageMaker notebook instances is security-sensitive                                                           | ✅  |     |     |     |     |
+| [aws-sagemaker-unencrypted-notebook](https://sonarsource.github.io/rspec/#/rspec/S6319/javascript)   | SageMaker notebook instances should be encrypted at rest                                                                       | ✅  |     |     |     |     |
 | [aws-sns-unencrypted-topics](https://sonarsource.github.io/rspec/#/rspec/S6327/javascript)           | Using unencrypted SNS topics is security-sensitive                                                                             | ✅  |     |     |     |     |
 | [aws-sqs-unencrypted-queue](https://sonarsource.github.io/rspec/#/rspec/S6330/javascript)            | SQS queues should be encrypted                                                                                                 | ✅  |     |     |     |     |
 | [bitwise-operators](https://sonarsource.github.io/rspec/#/rspec/S1529/javascript)                    | Bitwise operators should not be used in boolean contexts                                                                       | ✅  |     |     | 💭  |     |
@@ -290,7 +290,7 @@ If you have any questions, encounter any bugs, or have feature requests, please
 | [no-redundant-optional](https://sonarsource.github.io/rspec/#/rspec/S4782/javascript)                | Optional property declarations should not use both '?' and 'undefined' syntax                                                  | ✅  |     | 💡  | 💭  |     |
 | [no-redundant-parentheses](https://sonarsource.github.io/rspec/#/rspec/S1110/javascript)             | Redundant pairs of parentheses should be removed                                                                               |     |     | 💡  |     | ❌  |
 | [no-reference-error](https://sonarsource.github.io/rspec/#/rspec/S3827/javascript)                   | Variables should be defined before being used                                                                                  |     |     |     |     |     |
-| [no-referrer-policy](https://sonarsource.github.io/rspec/#/rspec/S5736/javascript)                   | Disabling strict HTTP no-referrer policy is security-sensitive                                                                 | ✅  |     |     |     |     |
+| [no-referrer-policy](https://sonarsource.github.io/rspec/#/rspec/S5736/javascript)                   | HTTP Referrer-Policy should not be set to an unsafe value                                                                      | ✅  |     |     |     |     |
 | [no-regex-spaces](https://sonarsource.github.io/rspec/#/rspec/S6326/javascript)                      | Regular expressions should not contain multiple spaces                                                                         | ✅  |     | 💡  | 💭  |     |
 | [no-require-or-define](https://sonarsource.github.io/rspec/#/rspec/S3533/javascript)                 | "import" should be used to include external code                                                                               |     |     |     | 💭  |     |
 | [no-return-type-any](https://sonarsource.github.io/rspec/#/rspec/S4324/javascript)                   | Primitive return types should be used                                                                                          |     |     |     | 💭  |     |
@@ -359,7 +359,7 @@ If you have any questions, encounter any bugs, or have feature requests, please
 | [stable-tests](https://sonarsource.github.io/rspec/#/rspec/S5973/javascript)                         | Tests should be stable                                                                                                         | ✅  |     |     |     |     |
 | [standard-input](https://sonarsource.github.io/rspec/#/rspec/S4829/javascript)                       | Reading the Standard Input is security-sensitive                                                                               |     |     |     |     | ❌  |
 | [stateful-regex](https://sonarsource.github.io/rspec/#/rspec/S6351/javascript)                       | Regular expressions with the global flag should be used with caution                                                           | ✅  |     |     |     |     |
-| [strict-transport-security](https://sonarsource.github.io/rspec/#/rspec/S5739/javascript)            | Disabling Strict-Transport-Security policy is security-sensitive                                                               | ✅  |     |     |     |     |
+| [strict-transport-security](https://sonarsource.github.io/rspec/#/rspec/S5739/javascript)            | HTTP Strict-Transport-Security policy should not be disabled                                                                   | ✅  |     |     |     |     |
 | [strings-comparison](https://sonarsource.github.io/rspec/#/rspec/S3003/javascript)                   | Comparison operators should not be used with strings                                                                           |     |     |     | 💭  |     |
 | [table-header](https://sonarsource.github.io/rspec/#/rspec/S5256/javascript)                         | Tables should have headers                                                                                                     | ✅  |     |     |     |     |
 | [table-header-reference](https://sonarsource.github.io/rspec/#/rspec/S5260/javascript)               | Table cells should reference their headers                                                                                     | ✅  |     |     |     |     |

sonar-plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/BridgeServerImpl.java

@@ -259,7 +259,7 @@ void establishWebSocketConnection() {
       this.client.connectBlocking();
     } catch (InterruptedException e) {
       Thread.currentThread().interrupt();
-      throw new RuntimeException(e);
+      throw new IllegalStateException("WebSocket connection interrupted", e);
     }
   }