chore(🐙): lock eas-cli and playwright via yarn.lock, remove deprecated expo-cli (#3796)

* Pin CI dependencies: lock eas-cli and playwright via yarn.lock, remove deprecated expo-cli

- Remove 'npm install -g expo-cli eas-cli' from all three jobs
  (test-skia-ios, test-skia-android, test-skia-web). expo-cli is
  deprecated upstream and the workflow already uses the local expo
  package via 'npx expo'. eas-cli is added as a devDependency instead.
- Remove 'npm install -g playwright' from test-skia-web. playwright is
  added as a devDependency and invoked via 'yarn playwright'.
- Replace all 'npx playwright' calls with 'yarn playwright'.
- Add eas-cli@18.4.0 and playwright@1.59.0 as devDependencies so their
  full transitive dependency trees are locked by yarn.lock.

npm install -g resolves the full transitive dependency tree from the npm
registry at install time with no lockfile. eas-cli pulls ~394 transitive
deps; expo-cli pulls ~986 (and is deprecated). npx is equally dangerous
as it does the same resolution at runtime. Adding these tools as
devDependencies locks the entire tree via yarn.lock.

* Add yarn install step before playwright commands in test-skia-web

The workflow checks out the repo but never ran yarn install, so
node_modules didn't exist. yarn playwright requires node_modules
to resolve the playwright binary from the lockfile.

* Replace all npx expo calls with yarn expo

npx has the same fetch-from-registry-without-lockfile risk as
npm install -g. The test apps are created with yarn create expo-app,
so expo is a local dependency and yarn expo works directly.

Author: thepwagner

.github/workflows/test-skia-package.yml

@@ -58,11 +58,6 @@ jobs:
           corepack enable
           yarn --version
 
-      - name: Install Expo CLI
-        run: |
-          npm install -g expo-cli eas-cli
-          expo --version
-
       - name: List available simulators
         run: xcrun simctl list devices
 
@@ -126,19 +121,19 @@ jobs:
         working-directory: /Users/runner/skia-test-app/my-app
         run: |
           echo "Installing TypeScript dependencies..."
-          npx expo install typescript @types/react
+          yarn expo install typescript @types/react
 
       - name: Install Expo Dev Client
         working-directory: /Users/runner/skia-test-app/my-app
         run: |
           echo "Installing expo-dev-client..."
-          npx expo install expo-dev-client
+          yarn expo install expo-dev-client
 
       - name: Prebuild native directories
         working-directory: /Users/runner/skia-test-app/my-app
         run: |
           echo "Generating native iOS directory..."
-          npx expo prebuild --platform ios
+          yarn expo prebuild --platform ios
 
       - name: Install iOS dependencies
         working-directory: /Users/runner/skia-test-app/my-app
@@ -151,14 +146,14 @@ jobs:
         working-directory: /Users/runner/skia-test-app/my-app
         run: |
           echo "Starting Metro bundler in background..."
-          npx expo start --dev-client &
+          yarn expo start --dev-client &
           sleep 10
 
       - name: Build and run iOS app
         working-directory: /Users/runner/skia-test-app/my-app
         run: |
           echo "Building and running iOS app on simulator: ${{ inputs.simulator_device }}..."
-          npx expo run:ios --device "${{ inputs.simulator_device }}"
+          yarn expo run:ios --device "${{ inputs.simulator_device }}"
 
       - name: Wait for app to launch
         run: |
@@ -215,11 +210,6 @@ jobs:
           corepack enable
           yarn --version
 
-      - name: Install Expo CLI
-        run: |
-          npm install -g expo-cli eas-cli
-          expo --version
-
       - name: Setup Java
         uses: actions/setup-java@v5
         with:
@@ -294,19 +284,19 @@ jobs:
         working-directory: /Users/runner/skia-test-app/my-app
         run: |
           echo "Installing TypeScript dependencies..."
-          npx expo install typescript @types/react
+          yarn expo install typescript @types/react
 
       - name: Install Expo Dev Client
         working-directory: /Users/runner/skia-test-app/my-app
         run: |
           echo "Installing expo-dev-client..."
-          npx expo install expo-dev-client
+          yarn expo install expo-dev-client
 
       - name: Prebuild native directories
         working-directory: /Users/runner/skia-test-app/my-app
         run: |
           echo "Generating native Android directory..."
-          npx expo prebuild --platform android
+          yarn expo prebuild --platform android
 
       - name: Start Android emulator
         run: |
@@ -325,14 +315,14 @@ jobs:
         working-directory: /Users/runner/skia-test-app/my-app
         run: |
           echo "Starting Metro bundler in background..."
-          npx expo start --dev-client &
+          yarn expo start --dev-client &
           sleep 10
 
       - name: Build and run Android app
         working-directory: /Users/runner/skia-test-app/my-app
         run: |
           echo "Building and running Android app on emulator..."
-          npx expo run:android
+          yarn expo run:android
 
       - name: Wait for app to launch
         run: |
@@ -384,11 +374,6 @@ jobs:
           corepack enable
           yarn --version
 
-      - name: Install Expo CLI
-        run: |
-          npm install -g expo-cli eas-cli
-          expo --version
-
       - name: Create test directory
         run: |
           mkdir -p /Users/runner/skia-test-app
@@ -449,20 +434,22 @@ jobs:
         working-directory: /Users/runner/skia-test-app/my-app
         run: |
           echo "Installing TypeScript dependencies..."
-          npx expo install typescript @types/react
+          yarn expo install typescript @types/react
+
+      - name: Install repo dependencies for Playwright
+        run: yarn install --immutable
 
       - name: Install Playwright dependencies
         run: |
           echo "Installing Playwright..."
-          npm install -g playwright
-          npx playwright install chromium
-          npx playwright install-deps chromium
+          yarn playwright install chromium
+          yarn playwright install-deps chromium
 
       - name: Start web server
         working-directory: /Users/runner/skia-test-app/my-app
         run: |
           echo "Starting web server in background..."
-          npx expo start --web &
+          yarn expo start --web &
           sleep 30
 
       - name: Wait for web app to be ready
@@ -476,7 +463,7 @@ jobs:
         if: always()
         run: |
           echo "Taking screenshot of web app..."
-          npx playwright screenshot http://localhost:8081 /Users/runner/skia-test-screenshot-web.png || echo "Failed to capture screenshot"
+          yarn playwright screenshot http://localhost:8081 /Users/runner/skia-test-screenshot-web.png || echo "Failed to capture screenshot"
 
       - name: Upload screenshot
         if: always()

package.json

@@ -35,6 +35,8 @@
     "@webgpu/types": "^0.1.69"
   },
   "devDependencies": {
+    "eas-cli": "18.4.0",
+    "playwright": "1.59.0",
     "react-native-test-app": "^4.2.0",
     "turbo": "^2.1.1"
   }