Fix 61. Bug with escaping value for customize_links_saml_login

pitbulk · web-flow · commit 01f028c2c5f5 · 2018-04-03T18:00:57.000+02:00
diff --git a/onelogin-saml-sso/php/configuration.php b/onelogin-saml-sso/php/configuration.php
@@ -369,7 +369,7 @@ function plugin_setting_string_onelogin_saml_customize_links_lost_password() {
 
 	function plugin_setting_string_onelogin_saml_customize_links_saml_login() {
 		echo '<input type="text" name="onelogin_saml_customize_links_saml_login" id="onelogin_saml_customize_links_saml_login"
-			  value= "'.esc_url(get_option('onelogin_saml_customize_links_saml_login')).'" size="80">
+			  value= "'.esc_attr(get_option('onelogin_saml_customize_links_saml_login')).'" size="80">
  			  <p class="description">'.__("If 'Keep Local login' enabled, this will be showed as message at the SAML link.", 'onelogin-saml-sso').'</p>';
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -369,7 +369,7 @@ function plugin_setting_string_onelogin_saml_customize_links_lost_password() {`
`369`	`369`
`370`	`370`	`function plugin_setting_string_onelogin_saml_customize_links_saml_login() {`
`371`	`371`	`echo '<input type="text" name="onelogin_saml_customize_links_saml_login" id="onelogin_saml_customize_links_saml_login"`
`372`		`- value= "'.esc_url(get_option('onelogin_saml_customize_links_saml_login')).'" size="80">`
	`372`	`+ value= "'.esc_attr(get_option('onelogin_saml_customize_links_saml_login')).'" size="80">`
`373`	`373`	`<p class="description">'.__("If 'Keep Local login' enabled, this will be showed as message at the SAML link.", 'onelogin-saml-sso').'</p>';`
`374`	`374`	`}`
`375`	`375`