Skip to content

Feedback sprint 5 #71

Description

@lkrombeen

sprint planning:

  • Prioritization is better. Adjust it slightly so the different categories are also prioritized e.g. which issue with priority label A is the most important, put that above the other issues with a label A.
  • Link back to user stories in your issues and add user stories to your project board..
  • You have many large tasks. Try splitting them into smaller tasks.
  • Some issue descriptions can be improved e.g. Upgrade GUI to allow zooming #53 what will be the action to zoom?
  • Last weeks estimation were okay (except Tycho) so there is no need to focus on improving that significantly.
    code evaluation
  • No commits to master, good.
  • You still are not closing the FileInputStreams and others.
  • The following statement in FileSelector is always true: chosenFile != null
  • Discussions in PRs are good, issues can be improved.
  • Add pictures to your README file.
  • Update your architecture document.
  • Good to see some tests. Still very minimal though. Are you using a tool like Cobertura? I currently get 5% branch coverage with is so maybe we have a mismatch? Because if that is the case, you deserve a higher grade ;)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions