tests broken?

[Seegras]

trying to make debian packages with dh_make results in it being unable to compile the test-cases. I suspect they are broken:

12 FAILED TESTS
0% tests passed, 1 tests failed out of 1
Total Test time (real) = 0.01 sec
The following tests FAILED:
1 - gtest-LoadTest (Failed)
Errors while running CTest
Makefile:130: recipe for target 'test' failed
make[1]: *** [test] Error 8
make[1]: Leaving directory '/usr/src/git/libfunctionality/obj-x86_64-linux-gnu'
dh_auto_test: make -j1 test ARGS+=-j1 returned exit code 2
debian/rules:18: recipe for target 'binary' failed

if they're broken, they should be either removed or fixed.

[rpavlik]

Hmm, sorry I missed this earlier. I was pretty sure that the Sensics CI had been building and running the tests on Windows and Linux, but clearly something was wrong if they failed for you. I'll look into it.

By any chance, do you have your progress on making a package available somewhere? I was intending to do that too.

[rpavlik]

OK, I looked into this. Looks like it's actually an rpath issue - we aren't using any particular search path in libfunctionality beyond just calling dlopen, so the test failures are because it can't find the dummy plugin that it wants.

I'm not sure what happened to make it fail now when it worked for me before, I'm assuming the rpath behavior of CMake must have changed. (I tried a very old commit, and it was broken there too even though a commit said "fix linux tests"... suggesting it's the environment not the code itself)

The code does actually work correctly, it's the tests that are faulty.

Bumping from the 1.0 project.