Commit 2eb882e
committed
Suppress DPC++/SYCL header deprecation warnings when building
Re-land of #2984. That PR was a stacked PR targeting the intermediate
branch `pin-conda-to-avoid-installing-faulty-build`, whose own PR
(#2982) was **closed, not merged**. As a result, #2984 was merged into
that dead intermediate branch and its changes never reached `master`.
GitHub won't allow reopening a merged PR, so this re-lands the identical
change directly against `master`.
This is a follow-up to #2856 and #2770. The `dpnp.tensor` target never
got the same `SYSTEM` treatment, so it was the one target still leaking
these warnings.
The Windows conda build produced a flood of `-Wdeprecated-declarations`
warnings (hundreds of thousands of lines in the CI log). All of them
originate inside the DPC++/SYCL headers themselves
(`.../Library/include/sycl/...`) — none come from dpnp's own sources —
so they are out of dpnp's control and are pure noise. They came
exclusively from the `dpnp.tensor` `_tensor_*_impl` pybind11 modules
built in `dpnp/tensor/CMakeLists.txt`.
In the `dpnp/tensor` target loop, split the include directories so
dpnp's own headers stay `PRIVATE`, and the third-party headers
(`SYCL_INCLUDE_DIR`, `Dpctl_INCLUDE_DIR`, generated Cython headers) are
added as `SYSTEM PRIVATE`, mirroring the pattern established in #2770
for the `backend/extensions/*` targets. 6671952dpnp.tensor on Windows (#2993)1 parent d8d3eae commit 2eb882e
2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1040 | 1040 | | |
1041 | 1041 | | |
1042 | 1042 | | |
1043 | | - | |
| 1043 | + | |
1044 | 1044 | | |
1045 | 1045 | | |
1046 | 1046 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments