From fa403f181a4d85df57b3b96a9a35e9442f5f68db Mon Sep 17 00:00:00 2001 From: Elliot Otchet Date: Fri, 14 Aug 2026 13:38:25 +0000 Subject: [PATCH] Update FROM to DUOS. --- .../consent/http/service/EmailService.java | 10 +++++++++- .../consent/http/service/EmailServiceTest.java | 2 ++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/broadinstitute/consent/http/service/EmailService.java b/src/main/java/org/broadinstitute/consent/http/service/EmailService.java index d0c132e9d..e35fa426c 100644 --- a/src/main/java/org/broadinstitute/consent/http/service/EmailService.java +++ b/src/main/java/org/broadinstitute/consent/http/service/EmailService.java @@ -43,6 +43,14 @@ public class EmailService implements ConsentLogger { private static final int LOOKBACK_DELAY_HOURS = 24; + + /** + * Friendly name shown as the sender of all outgoing SendGrid messages. Without it, the From + * header carries a bare address and mail clients typically display the local part instead - + * 'duos', for the production account. + */ + private static final String FROM_NAME = "DUOS"; + @VisibleForTesting protected static int sendgridThrottleMessageCount = 500; @VisibleForTesting protected static int sendgridThrottleResetTime = 60; private final UserDAO userDAO; @@ -80,7 +88,7 @@ public void sendMessage(MailMessage mailMessage, Integer userId) String content = out.toString(); Mail message = new Mail( - new Email(fromAccount), + new Email(fromAccount, FROM_NAME), mailMessage.createSubject(), new Email(mailMessage.toUser.getEmail()), new Content("text/html", content)); diff --git a/src/test/java/org/broadinstitute/consent/http/service/EmailServiceTest.java b/src/test/java/org/broadinstitute/consent/http/service/EmailServiceTest.java index a5cd4b323..0591c9f6d 100644 --- a/src/test/java/org/broadinstitute/consent/http/service/EmailServiceTest.java +++ b/src/test/java/org/broadinstitute/consent/http/service/EmailServiceTest.java @@ -69,6 +69,7 @@ class EmailServiceTest extends AbstractTestHelper { private static final String SERVER_URL = "http://localhost:8000/#/"; private static final String FROM = "from@duos"; + private static final String FROM_NAME = "DUOS"; private EmailService service; @Mock private ElectionDAO electionDAO; @Mock private UserDAO userDAO; @@ -137,6 +138,7 @@ void testSendMessage() throws Exception { verify(sendGridAPI).sendMessage(captor.capture(), eq(user.getEmail())); var mail = captor.getValue(); assertEquals(FROM, mail.getFrom().getEmail()); + assertEquals(FROM_NAME, mail.getFrom().getName()); assertEquals( user.getEmail(), mail.getPersonalization().getFirst().getTos().getFirst().getEmail()); assertEquals(subject, mail.getSubject());