fix isProperFraction per reviewer feedback

Author: Vaidah-dev

implement-and-rewrite-tests/implement-tests-with-node-test/2-is-proper-fraction.test.js

@@ -8,7 +8,7 @@ test("Improper fraction (numerator > denominator)", () => {
 });
 
 test("Zero cases", () => {
-  assert.equal(isProperFraction(0, 1), true);
+  assert.equal(isProperFraction(0, 1), false);
   assert.equal(isProperFraction(1, 0), false);
   assert.equal(isProperFraction(0, 0), false);
 });
@@ -18,12 +18,11 @@ test("Equal numerator and denominator", () => {
 });
 
 test("Negative cases", () => {
-  assert.equal(isProperFraction(-2, 1), true);
+  assert.equal(isProperFraction(-2, 1), false);
   assert.equal(isProperFraction(1, -2), false);
-  assert.equal(isProperFraction(-1, -2), false);
+  assert.equal(isProperFraction(-1, -2), true);
 });
 
 test("Basic proper fraction", () => {
-  // Example: 1/2 is a proper fraction
   assert.equal(isProperFraction(1, 2), true);
 });

implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -1,3 +1,4 @@
 export function isProperFraction(numerator, denominator) {
-  return numerator < denominator;
+  const value = numerator / denominator;
+  return value > 0 && value < 1;
 }

implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -7,7 +7,7 @@ test(`should return false when denominator is zero`, () => {
 test("Basic proper fraction", () => {
   expect(isProperFraction(1, 2)).toEqual(true);
   expect(isProperFraction(2, 1)).toEqual(false);
-  expect(isProperFraction(-2, 1)).toEqual(true);
+  expect(isProperFraction(-2, 1)).toEqual(false);
   expect(isProperFraction(1, -2)).toEqual(false);
 });
 
@@ -16,7 +16,7 @@ test("Improper fraction (numerator > denominator)", () => {
 });
 
 test("Zero cases", () => {
-  expect(isProperFraction(0, 1)).toEqual(true);
+  expect(isProperFraction(0, 1)).toEqual(false);
   expect(isProperFraction(1, 0)).toEqual(false);
   expect(isProperFraction(0, 0)).toEqual(false);
 });
@@ -26,7 +26,7 @@ test("Equal numerator and denominator", () => {
 });
 
 test("Negative cases", () => {
-  expect(isProperFraction(-2, 1)).toEqual(true);
+  expect(isProperFraction(-2, 1)).toEqual(false);
   expect(isProperFraction(1, -2)).toEqual(false);
-  expect(isProperFraction(-1, -2)).toEqual(false);
+  expect(isProperFraction(-1, -2)).toEqual(true);
 });